855619 - Theme Edit is slow to POST

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Code Quality, enhancement, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

After POSTing the server takes a while to get back to us. It's tough to tell what the bottleneck is. Consider doing EditThemeForm.save()'s logic in a task or something: https://github.com/mozilla/zamboni/blob/master/apps/addons/forms.py#L651

Here are our saves:

   [Min, Max]  Query   Model
   ----------  ------  -------------
1. [1, 1]      UPDATE  Addon
2. [0, 1]      UPDATE  Persona
3. [0, +Inf)   INSERT  Tag
4. [0, +Inf)   DELETE  Tag
5. [0, 1]      UPDATE  AddonCategory

Comment 1

[Wil Clouser [:clouserw]]

task seems excessive for this since we want it to respond right away.  We should figure out what is slow and fix that.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

We can do all of this asynchronously with a Celery task. If the slug has changed, we should redirect to the edit URL with that new slug, and we'll assume everything got inserted/updated/deleted without any issues. I can get behind that.

Comment 3

[Wil Clouser [:clouserw]]

Why would you do this asynchronously?  Editing live data is one of the main reasons to do this real time.  If we don't, you end up with all the weird caching problems we had in AMO, or special cases to make those problems not show up.  Isn't it way easier just to make sure the inserts are fast?  We should figure out why queries are slow - they could be slowing other things down too.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

Not sure what is actually slow here - I'm actually being kind of smart and saving only when the columns change value. To investigate later.

Comment 5

[Kevin Ngo [:ngoke]]

Here are some timings on my local server, just from clicking Save without editing any data on the form. 

--------LOADED FORM
0:00:00.013743
--------SAVED PERSONA
0:00:00.000046
--------SAVED ADDON OBJECT
0:00:00.071135
--------ADDED NEW TAGS
0:00:00.002261
--------REMOVED OLD TAGS
0:00:00.000009
--------UPDATED CATEGORY
0:00:00.002190

Comment 6

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/bc3160c8e75d8dee819b357d00c4012e1427c60c

Try .values_list() over list comprehension + .all()

Comment 7

[Kevin Ngo [:ngoke]]

PR https://github.com/mozilla/zamboni/pull/914

Comment 8

[Kevin Ngo [:ngoke]]

I'm posting a 30x speedup locally (.0800s vs .0025s zomg) when the add-on itself is not modified on POST.

Doesn't affect it on -dev though. -dev seems to still take 4 seconds from clicking the button to the page finish loading. Might not be a direct code issue.

Comment 9

[Kevin Ngo [:ngoke]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/

Comment 10

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/