855700 - Returning an nsIVariant from WebIDL doesn't work

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is needed for bug 851542 for now until we have IDL arrays.  But it might come up for something else too.

The basic problem is that we treat nsIVariant as an external interface, call dom::WrapObject<nsIVariant>, which calls dom::XPCOMObjectToJsval, which calls dom::NativeInterface2JSObjectAndThrowIfFailed, which calls XPCConvert::NativeInterface2JSObject.

And that fails, in a web page, because variants have no classinfo.

The point, of course, is we don't want to create a wrapper for a variant at all.  Note that XPCConvert::NativeData2JS special-cases nsIVariant in the nsXPTType::T_INTERFACE case by calling XPCVariant::VariantDataToJS.  We need to do something similar.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make returning an nsIVariant from a WebIDL interface work.

Comment 2

[(not currently active) Ted Mielczarek]

This makes the patch in bug 851542 work for me.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 730682 [details] [diff] [review]
Make returning an nsIVariant from a WebIDL interface work.

Exception handling is a bit ugly, but should at least be safe.
I don't think we handle exceptions too consistently with VariantDataToJS.

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db4edcd5986e

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Hmm, looks like I'm getting crash because iid is null.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

debug only assertion crash.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

MOZ_ASSERT(!iid || iid->Equals(NS_GET_IID(nsIVariant)));
for now.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Does putting back the notflattened=True help?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db4edcd5986e