851542 - WebIDL-ify Gamepad API

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[(not currently active) Ted Mielczarek]

Ms2ger started on this, but we decided to punt on it for initial landing.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: Gamepad to webidl (with nsIVariant)

This still needs a parent object, but that seemed to be fairly easy from what I heard from Ted.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Remove nsIDOMGamepad's members

We still need to have the interface around until we move the events to webidl-only; not sure how much work that still needs from smaug.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: Part a: Gamepad to webidl (with nsIVariant)

I had to tweak a few things to make this work, but this runs and passes tests now. Notably we need the patch from bug 855700 so that the nsIVariant members can actually get exposed to content.

This also hooks up cycle collection of the nsGlobalWindow's mGamepads, since each gamepad now holds a ref back to its parent window. This depends on the patch in bug 855804.

Comment 4

[(not currently active) Ted Mielczarek]

Attachment: Gamepad to webidl (with nsIVariant)

Folded in part b. This works, so I think it's good enough.

Comment 5

[(not currently active) Ted Mielczarek]

I think this is "good enough" without bug 850159. The implementation isn't any worse than it already is. Once we get support for WebIDL arrays we can get rid of the variant goop.

Comment 6

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dcf67f13c6bb

Comment 7

[(not currently active) Ted Mielczarek]

...and backed out because it broke B2G where gamepad is disabled:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90ae6736f95e

Comment 8

[(not currently active) Ted Mielczarek]

Attachment: Gamepad to webidl (with nsIVariant).

I neglected to ifdef the webidl, which is what caused the bustage that caused the backout. Here's a fixed patch that I'll reland when the tree is open.

Comment 9

[(not currently active) Ted Mielczarek]

re-landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfed7579f792

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dfed7579f792