Closed Bug 851542 Opened 7 years ago Closed 7 years ago

WebIDL-ify Gamepad API

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: ted, Assigned: Ms2ger)

References

Details

Attachments

(1 file, 4 obsolete files)

Ms2ger started on this, but we decided to punt on it for initial landing.
OS: Linux → All
Hardware: x86_64 → All
Depends on: 850159
This still needs a parent object, but that seemed to be fairly easy from what I heard from Ted.
We still need to have the interface around until we move the events to webidl-only; not sure how much work that still needs from smaug.
Depends on: 855804
I had to tweak a few things to make this work, but this runs and passes tests now. Notably we need the patch from bug 855700 so that the nsIVariant members can actually get exposed to content.

This also hooks up cycle collection of the nsGlobalWindow's mGamepads, since each gamepad now holds a ref back to its parent window. This depends on the patch in bug 855804.
Folded in part b. This works, so I think it's good enough.
Attachment #731145 - Flags: review?(bugs)
Attachment #731121 - Attachment is obsolete: true
Attachment #728933 - Attachment is obsolete: true
Attachment #728935 - Attachment is obsolete: true
I think this is "good enough" without bug 850159. The implementation isn't any worse than it already is. Once we get support for WebIDL arrays we can get rid of the variant goop.
No longer depends on: 850159
Blocks: 856373
Attachment #731145 - Flags: review?(bugs) → review+
...and backed out because it broke B2G where gamepad is disabled:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90ae6736f95e
I neglected to ifdef the webidl, which is what caused the bustage that caused the backout. Here's a fixed patch that I'll reland when the tree is open.
Attachment #731145 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/dfed7579f792
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.