Closed Bug 855765 Opened 11 years ago Closed 10 years ago

Intermittent test_bug_795164.html | test_bug_795164.xul | Test timed out, test_cross_origin.xul | Test timed out, test_getNotInstalled.xul | Test timed out, test_install_app.xul | Test timed out, | 4 test timeouts, giving up | Skipping 468 remaining tests

Categories

(Core Graveyard :: DOM: Apps, defect)

Product:
Core Graveyard
Component:
DOM: Apps
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(firefox25 fixed, firefox26 fixed, firefox27 fixed, firefox-esr24 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla27
Tracking Flags:
Tracking Status
firefox25 --- fixed
firefox26 --- fixed
firefox27 --- fixed
firefox-esr24 --- fixed

People

(Reporter: philor, Assigned: marco)

Details

(Keywords: intermittent-failure, Whiteboard: [test which aborts the suite][apps-automation:P3])

Attachments

(1 file, 1 obsolete file)

Patch
8.19 KB, patch
marco
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=21193003&tree=Firefox
WINNT 6.2 mozilla-central pgo test mochitest-other on 2013-03-27 22:54:11 PDT for push 962f5293f87f
slave: t-w864-ix-009

23:00:33     INFO -  10116 INFO TEST-START | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_bug_795164.xul
23:05:48     INFO -  10117 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_bug_795164.xul | Test timed out.
(screenshot)
23:05:49     INFO -  10118 INFO TEST-END | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_bug_795164.xul | finished in 315202ms
23:05:49     INFO -  10119 INFO TEST-START | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_cross_origin.xul
23:11:16     INFO -  10120 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_cross_origin.xul | Test timed out.
23:11:16     INFO -  Not taking screenshot here: see the one that was previously logged
23:11:17     INFO -  10121 INFO TEST-END | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_cross_origin.xul | finished in 328207ms
23:11:17     INFO -  10122 INFO TEST-START | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_getNotInstalled.xul
23:16:45     INFO -  10123 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_getNotInstalled.xul | Test timed out.
23:16:45     INFO -  Not taking screenshot here: see the one that was previously logged
23:16:46     INFO -  10124 INFO TEST-END | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_getNotInstalled.xul | finished in 328789ms
23:16:46     INFO -  10125 INFO TEST-START | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_install_app.xul
23:16:46     INFO -  10126 INFO TEST-PASS | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_install_app.xul | getInstalled() returns nothing
23:22:14     INFO -  10127 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_install_app.xul | Test timed out.
23:22:14     INFO -  Not taking screenshot here: see the one that was previously logged
23:22:14     INFO -  10128 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | 4 test timeouts, giving up.
23:22:14     INFO -  10129 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | Skipping 468 remaining tests.
23:22:15     INFO -  10130 ERROR TEST-UNEXPECTED-FAIL | (SimpleTest/TestRunner.js) | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_install_app.xul finished in a non-clean fashion, probably because it didn't call SimpleTest.finish()
Hmm...the only patch I see landed recently that touched the dom:apps code was the install package support on Fx Android.

Fabrice - Could that be what caused this to regress?
Flags: needinfo?(fabrice)
I don't see how the code that landed could cause this surge in intermittent failures, but it's worth keeping an eye on it.
Flags: needinfo?(fabrice)
Whiteboard: [test which aborts the suite] → [test which aborts the suite][apps-automation]
Whiteboard: [test which aborts the suite][apps-automation] → [test which aborts the suite][apps-automation:P3]
(OrangeWFM for bugs not modified in > 2 months)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
I think for this and for bug 859631 we should skip the UI confirmation prompt.
Attached patch Patch (obsolete) — — Splinter Review 
Same as bug 859631, try run here: https://tbpl.mozilla.org/?tree=Try&rev=c27ed70cdf30
Attachment #807988 - Flags: review?(fabrice)
Comment on attachment 807988 [details] [diff] [review]
Patch

Review of attachment 807988 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/tests/test_bug_795164.html
@@ +44,5 @@
>  
> +    // Keeping track of the number of times `mozApps.mgmt.onuninstall` gets triggered
> +    let uninstallCount = 0;
> +
> +    navigator.mozApps.mgmt.onuninstall = function onUnInstall() {

nit: no need to name the function.
Attachment #807988 - Flags: review?(fabrice) → review+
Attached patch Patch — — Splinter Review 
Carrying r+.
Assignee: nobody → mcastelluccio
Attachment #807988 - Attachment is obsolete: true
Status: REOPENED → ASSIGNED
Attachment #809350 - Flags: review+
Let's see if this fixes the intermittent failure.
Keywords: checkin-needed
Whiteboard: [test which aborts the suite][apps-automation:P3] → [test which aborts the suite][apps-automation:P3][leave open]
https://hg.mozilla.org/integration/fx-team/rev/dba79b51d04b
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [test which aborts the suite][apps-automation:P3][leave open] → [test which aborts the suite][apps-automation:P3][leave open][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/dba79b51d04b
Whiteboard: [test which aborts the suite][apps-automation:P3][leave open][fixed-in-fx-team] → [test which aborts the suite][apps-automation:P3][leave open]
Notice that the test name has changed, so these two test failures don't matter.
Summary: Intermittent test_bug_795164.xul | Test timed out, test_cross_origin.xul | Test timed out, test_getNotInstalled.xul | Test timed out, test_install_app.xul | Test timed out, | 4 test timeouts, giving up, | Skipping 468 remaining tests → Intermittent test_bug_795164.html | test_bug_795164.xul | Test timed out, test_cross_origin.xul | Test timed out, test_getNotInstalled.xul | Test timed out, test_install_app.xul | Test timed out, | 4 test timeouts, giving up | Skipping 468 remaining tests
Let's call this fixed.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-aurora/rev/1f0a499a8e1c

I'll land this on beta and esr24 also as a ride-along the next time I'm pushing there.
status-firefox25: --- → affected
status-firefox26: --- → fixed
status-firefox27: --- → fixed
status-firefox-esr24: --- → affected
Target Milestone: --- → mozilla27
https://hg.mozilla.org/releases/mozilla-esr24/rev/ce235bf4aedb
status-firefox-esr24: affected → fixed
Whiteboard: [test which aborts the suite][apps-automation:P3][leave open] → [test which aborts the suite][apps-automation:P3]
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I'd open a new bug, this one about test_bug_795164.xul was fixed.
The original failure was fixed, I think we should open a new bug for other failures.

In particular, the latest failures are bug 961317.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite+ → in-testsuite?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: