Closed Bug 855771 Opened 12 years ago Closed 12 years ago

TEST-UNEXPECTED-FAIL | tests/test-tab-utils.testGetTabs | there is one tab found - 1 == 2

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(firefox24 wontfix, firefox25 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla25
Tracking Flags:
Tracking Status
firefox24 --- wontfix
firefox25 --- fixed

People

(Reporter: KWierso, Assigned: evold)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled])

Attachments

(1 file, 1 obsolete file)

Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/998
355 bytes, text/html
jsantell
: review+
Details
Only seeing this once so far... TEST-UNEXPECTED-FAIL | tests/test-tab-utils.testGetTabs | there is one tab found - 1 == 2 TEST-INFO | Traceback (most recent call last): File "resource://extensions.modules.f04d62c1-4d59-40e3-b4b5-a39137f9c885-at-jetpack.commonjs.path/sdk/window/helpers.js", line 36, in eventHandler deferred.resolve(target); File "resource://extensions.modules.f04d62c1-4d59-40e3-b4b5-a39137f9c885-at-jetpack.commonjs.path/sdk/core/promise.js", line 187, in resolve result.then(observer.resolve, observer.reject); File "resource://extensions.modules.f04d62c1-4d59-40e3-b4b5-a39137f9c885-at-jetpack.commonjs.path/sdk/core/promise.js", line 45, in then return { then: function then(fulfill) { fulfill(value); } }; File "resource://extensions.modules.f04d62c1-4d59-40e3-b4b5-a39137f9c885-at-jetpack.commonjs.path/sdk/core/promise.js", line 120, in resolve deferred.resolve(onFulfill ? onFulfill(value) : value); File "resource://extensions.modules.f04d62c1-4d59-40e3-b4b5-a39137f9c885-at-jetpack.commonjs.path.tests/test-tab-utils.js", line 44, in exports.testGetTabs/< assert.equal(getTabs().length, 1, 'there is one tab found'); File "resource://extensions.modules.f04d62c1-4d59-40e3-b4b5-a39137f9c885-at-jetpack.commonjs.path/sdk/test/assert.js", line 125, in equal operator: "==" File "resource://extensions.modules.f04d62c1-4d59-40e3-b4b5-a39137f9c885-at-jetpack.commonjs.path/sdk/test/assert.js", line 89, in fail this._log.fail(message); File "resource://extensions.modules.f04d62c1-4d59-40e3-b4b5-a39137f9c885-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 84, in fail this.console.testMessage(false, false, this.test.name, message); File "resource://extensions.modules.f04d62c1-4d59-40e3-b4b5-a39137f9c885-at-jetpack.commonjs.path/sdk/test/harness.js", line 380, in testMessage this.trace();
OS: Windows 8 → All
Priority: -- → P2
Hardware: x86_64 → All
Bumping priority since it suddenly seems much more frequent.
Priority: P2 → P1
There is a chance that this bug is going to be fixed by bug 858970. We can see in log that the tab from the window that we weren't waiting for final destroy event is being destroyed after the assertion fails...
Good, because this is currently a top-10 orange.
It looks like my work didn't pay... Shouldn't we consider disabling this test? In anycase, this bug requires an owner!
Flags: needinfo?(dtownsend+bugmail)
Depends on: 863456
I've disabled this test for now until I can get bug 863456 working: https://hg.mozilla.org/integration/mozilla-inbound/rev/c9135550a85f
Flags: needinfo?(dtownsend+bugmail)
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/ae8341977da16e9d3d79e4bb173432527919cf6a Bug 855771: Disable tab-utils test for frequent intermittent failures.
Whiteboard: [test disabled]
https://hg.mozilla.org/mozilla-central/rev/c9135550a85f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Er, we should leave this open to actually fix the test, no?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Commit pushed to integration at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/ae8341977da16e9d3d79e4bb173432527919cf6a Bug 855771: Disable tab-utils test for frequent intermittent failures.
Assignee: nobody → evold
Attachment #750255 - Flags: review?(zer0)
Attachment #750256 - Attachment is obsolete: true
(In reply to TinderboxPushlog Robot from comment #200) > philor > https://tbpl.mozilla.org/php/getParsedLog.php?id=23491799&tree=Mozilla-Beta > Ubuntu VM 12.04 mozilla-beta pgo test jetpack on 2013-05-28 11:31:39 > slave: tst-linux32-ec2-025 > > TEST-UNEXPECTED-FAIL | tests/test-tab-utils.testGetTabs | there is one tab > found - 1 == 2 Weird.. after the changes in https://github.com/mozilla/addon-sdk/pull/998/files the 'there is one tab' string is no longer in https://github.com/erikvold/addon-pathfinder/blob/a020364bb0b2b4e2691773c9cc020189aca75231/test/test-tab-utils.js so it seems like this file wasn't updated.
Assignee: evold → nobody
That test failure (and most/all of the recent failures in this bug) was on Mozilla-Beta, and I don't believe pull request 998 has made it that far down the train.
Comment on attachment 750255 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/998 I request this review 2 months ago, moving to someone else.
Attachment #750255 - Flags: review?(zer0) → review?(jsantell)
Comment on attachment 750255 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/998 Looks good -- yes, yes, let's get this in master. Poor TinderboxPushlog Robot.
Attachment #750255 - Flags: review?(jsantell) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/a020364bb0b2b4e2691773c9cc020189aca75231 Bug 855771: enable test-tab-utils.js, remove tab/window count assumption https://github.com/mozilla/addon-sdk/commit/729d1e3602aa4cf3405f2db886db2a10a231138d Merge pull request #998 from erikvold/855771 Bug 855771: enable test-tab-utils.js, remove tab/window count assumption r=@jsantell
Merged in, good to close?
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Assignee: nobody → evold
status-firefox24: --- → affected
status-firefox25: --- → fixed
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: