TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-windows.testWindowOpenPrivateDefault

RESOLVED FIXED

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: KWierso, Assigned: erikvold)

Tracking

({intermittent-failure})

unspecified
All
Windows 7
intermittent-failure

Firefox Tracking Flags

(firefox37 wontfix, firefox38 wontfix, firefox39 fixed, firefox-esr31 unaffected)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
This appears to be permanently failing on beta against Win7Debug builds.

https://tbpl.mozilla.org/php/getParsedLog.php?id=21506204&tree=Jetpack&full=1#error0

builder: jetpack-mozilla-beta-win7-debug
slave: talos-r3-w7-087
starttime: 1365246640.68
results: warnings (1)
revision: b2e32dab15b6aff5e700423dfda84b3bb88a47ca

TEST-UNEXPECTED-FAIL | tests/test-windows.testWindowOpenPrivateDefault | Test run exceeded timeout (1800s).

Traceback (most recent call last):

  File "bin/cfx", line 33, in <module>

    cuddlefish.run()

  File "C:\talos-slave\test\addonsdk-poller\addon-sdk-b2e32dab15b6\python-lib\cuddlefish\__init__.py", line 611, in run

    test_all(env_root, defaults=options.__dict__)

  File "C:\talos-slave\test\addonsdk-poller\addon-sdk-b2e32dab15b6\python-lib\cuddlefish\__init__.py", line 391, in test_all

    test_all_packages(env_root, defaults)

  File "C:\talos-slave\test\addonsdk-poller\addon-sdk-b2e32dab15b6\python-lib\cuddlefish\__init__.py", line 484, in test_all_packages

    env_root=env_root)

  File "C:\talos-slave\test\addonsdk-poller\addon-sdk-b2e32dab15b6\python-lib\cuddlefish\__init__.py", line 928, in run

    bundle_sdk=options.bundle_sdk)

  File "C:\talos-slave\test\addonsdk-poller\addon-sdk-b2e32dab15b6\python-lib\cuddlefish\runner.py", line 746, in run_app

    RUN_TIMEOUT, test_name, parseable)

Exception: Test run exceeded timeout (1800s).

TinderboxPrint:Jetpack<br/>211/0
Alex can you please take a look at this too ?
Assignee: nobody → poirot.alex
(Reporter)

Updated

5 years ago
Priority: -- → P2
Created attachment 737481 [details]
Pull request 941

I'm not 100% sure it will fix this bug, but we can see in middle of testWindowOpenPrivateDefault a mention of the tab "tab 2" opened during testWindowTabsObject_alt and found this obvious issue.

If it fix timeout for testWindowOpenPrivateDefault, it may also fix various other timeout we are seeing about window tests on win7debug!
Attachment #737481 - Flags: review?(evold)
Attachment #737481 - Flags: review?(evold) → review+
just one nit
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #3)
> just one nit

oh sry meant to say this in bug 858954
still r+ here.

Comment 6

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/03aaa81748ac740989b30672c92112f4e0710b5a
Bug 858970 - Wait for tab close before switching to next test in testWindowTabsObject_alt.

https://github.com/mozilla/addon-sdk/commit/33ae5f9dea2dacfbe4307e66b8f8275ee4274244
Merge pull request #941 from ochameau/bug858970

Bug 858970 - Wait for tab close before switching to next test in testWindowTabsObject_alt. r=@erikvold
Various errors still happen in windows related tests, but this one didn't show up.
Do not hesitate to reopen if it reappears.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 8

5 years ago
Commits pushed to integration at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/03aaa81748ac740989b30672c92112f4e0710b5a
Bug 858970 - Wait for tab close before switching to next test in testWindowTabsObject_alt.

https://github.com/mozilla/addon-sdk/commit/33ae5f9dea2dacfbe4307e66b8f8275ee4274244
Merge pull request #941 from ochameau/bug858970
Assignee: poirot.alex → nobody
Status: RESOLVED → REOPENED
Priority: P2 → P1
Resolution: FIXED → ---
Summary: TEST-UNEXPECTED-FAIL | tests/test-windows.testWindowOpenPrivateDefault | Test run exceeded timeout (1800s). → TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-windows.testWindowOpenPrivateDefault
Blocks: 1111478
Comment hidden (Treeherder Robot)
Assignee: nobody → evold
Created attachment 8578768 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1899
Attachment #8578768 - Flags: review?(jsantell)
Attachment #8578768 - Flags: review?(jsantell) → review+

Comment 11

3 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/797669086acdbe5e313cfc1eb370261fa51a19a3
Bug 858970 - TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-windows.testWindowOpenPrivateDefault

https://github.com/mozilla/addon-sdk/commit/45704e98600545b61b5d79685208856cc1968c7d
Merge pull request #1899 from erikvold/858970

Bug 858970 - TEST-UNEXPECTED-FAIL | addon-sdk/tests/test-windows.testWindowOpenPrivateDefault r=jsantell
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago3 years ago
Resolution: --- → FIXED
status-firefox37: --- → wontfix
status-firefox38: --- → wontfix
status-firefox39: --- → fixed
status-firefox-esr31: --- → unaffected
You need to log in before you can comment on or make changes to this bug.