855823 - Compute file_id from mapped libraries instead of relying on AddLibraryMapping caller to provide it

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Mike Hommey [:glandium]]

This will allow to get rid of the lib.id file on Android.

This requires http://breakpad.appspot.com/544003/ (which depends on a bunch of others)

Comment 1

[Mike Hommey [:glandium]]

Attachment: WIP

Comment 2

[Mike Hommey [:glandium]]

Attachment: Rely on breakpad finding file ids itself instead of relying on AddLibraryMapping caller to provide them

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 732345 [details] [diff] [review]
Rely on breakpad finding file ids itself instead of relying on AddLibraryMapping caller to provide them

Review of attachment 732345 [details] [diff] [review]:
-----------------------------------------------------------------

If we're not using the lib.id stuff anymore we could remove toolkit/crashreporter/fileid/.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/39902799d11b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/39902799d11b