Closed Bug 855846 Opened 7 years ago Closed 7 years ago

sanitizeme.pl should disable email for all users as well as filter the email address

Categories

(bugzilla.mozilla.org :: General, enhancement)

Production
enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dkl, Assigned: dkl)

Details

Attachments

(1 file, 2 obsolete files)

sanitizeme.pl should disable email delivery for all accounts in the profiles table. Additionally we will filter the email addresses in case email delivery is turned on for users by mistake. This will simple replace @ with _at_ and . with _dot_.

Patch coming up
dkl
Attached patch Patch to sanitizeme.pl (v1) (obsolete) — Splinter Review
Attachment #730878 - Flags: review?(glob)
Comment on attachment 730878 [details] [diff] [review]
Patch to sanitizeme.pl (v1)

>+    $keep_passwords, $keep_insider, $trace, $leave_email) = (0, 0, 0, '', 0, 0, 0);

Need another argument to the initializer.
Attached patch Patch to sanitizeme.pl (v2) (obsolete) — Splinter Review
Thanks Reed. Missed that. New patch.
Attachment #730878 - Attachment is obsolete: true
Attachment #730878 - Flags: review?(glob)
Attachment #731195 - Flags: review?(glob)
Comment on attachment 731195 [details] [diff] [review]
Patch to sanitizeme.pl (v2)

i don't think replacing @ and . in emails is a good approach, as it will cause all the emails fail to pass the 'emailregexp' validation.

i think just disabling bugmail for all users will be sufficient.

you also need to clear the cc fields for flags, as they trigger email to recipients which aren't bugzilla users.
Attachment #731195 - Flags: review?(glob) → review-
(In reply to Byron Jones ‹:glob› from comment #4)
> i think just disabling bugmail for all users will be sufficient.

Ok. Done.

> you also need to clear the cc fields for flags, as they trigger email to
> recipients which aren't bugzilla users.

Ugh. Forgot that part. Thank glob we have the review process :)

dkl
Attachment #731195 - Attachment is obsolete: true
Attachment #732041 - Flags: review?(glob)
Comment on attachment 732041 [details] [diff] [review]
Patch to sanitizeme.pl (v3)

r=glob
Attachment #732041 - Flags: review?(glob) → review+
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2             
modified contrib/sanitizeme.pl
Committed revision 8716.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.