855846 - sanitizeme.pl should disable email for all users as well as filter the email address

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement)

Description

[David Lawrence [:dkl]]

sanitizeme.pl should disable email delivery for all accounts in the profiles table. Additionally we will filter the email addresses in case email delivery is turned on for users by mistake. This will simple replace @ with _at_ and . with _dot_.

Patch coming up
dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to sanitizeme.pl (v1)

Comment 2

[Reed Loden [:reed]]

Comment on attachment 730878 [details] [diff] [review]
Patch to sanitizeme.pl (v1)

>+    $keep_passwords, $keep_insider, $trace, $leave_email) = (0, 0, 0, '', 0, 0, 0);

Need another argument to the initializer.

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to sanitizeme.pl (v2)

Thanks Reed. Missed that. New patch.

Comment 4

[:glob ✱]

Comment on attachment 731195 [details] [diff] [review]
Patch to sanitizeme.pl (v2)

i don't think replacing @ and . in emails is a good approach, as it will cause all the emails fail to pass the 'emailregexp' validation.

i think just disabling bugmail for all users will be sufficient.

you also need to clear the cc fields for flags, as they trigger email to recipients which aren't bugzilla users.

Comment 5

[David Lawrence [:dkl]]

Attachment: Patch to sanitizeme.pl (v3)

(In reply to Byron Jones ‹:glob› from comment #4)
> i think just disabling bugmail for all users will be sufficient.

Ok. Done.

> you also need to clear the cc fields for flags, as they trigger email to
> recipients which aren't bugzilla users.

Ugh. Forgot that part. Thank glob we have the review process :)

dkl

Comment 6

[:glob ✱]

Comment on attachment 732041 [details] [diff] [review]
Patch to sanitizeme.pl (v3)

r=glob

Comment 7

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.2             
modified contrib/sanitizeme.pl
Committed revision 8716.