855911 - Handle favicon creation and scaling in browser.js, not in Java

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Nvidia is sending us an ico file. Java grabs the last icon in the file (I think). We have no control over this AFAIK, but in Gecko we do. It might be better if we could do all our favicon resizing in Gecko regardless, where we have more control over the resample algorithms.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: WIP Patch

I want to clean this up and play with it a bit more, but getting there.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

This moves our favicon creation and scaling to browser.js (we're caching these in Favicons.java, so for the most part any speed hit should be small?). It sends pass a data-uri with the favicon to Java now. If there is no icon, java would previously attempt to use favicon.ico. This has the Java frontend send a message to Gecko requesting the favicon.ico icon be loaded instead.

I also duplicated our scaling code here. If the icon is the same size or more than a minimum, we scale it up, otherwise we scale down. The big benefit here though is just that we can pick better icons from ico images than we could with Android's bitmap decoder.

Comment 4

[Chris Kitching [:ckitching]]

Fixed by patch on Bug 748100.

https://www.dropbox.com/s/dd8aj12yektrah3/NvidiaFix.png

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Fixed by Bug 748100.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

That hasn't landed yet, has it?

Comment 7

[Chris Kitching [:ckitching]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #6)
> That hasn't landed yet, has it?

Correct. This is fixed by the ICODecoder which is yet to land.

Feel free to steal that bug, anyone who is bored and has this mythical "Free time".

Comment 8

[Richard Newman [:rnewman]]

I think the correct resolution for this is "WONTFIX in favor of…" -- we can reopen it later if there's some pressing need to do the work in Gecko, but in the mean time the landed-and-forthcoming Java stuff will solve the issue.