855971 - Switch HTMLDocument to WebIDL bindings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The bug we used to have on this got repurposed.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v2

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 743209 [details] [diff] [review]
v2

>+    is(globalScope.querySelectorAll(".variables-view-variable:not([non-match])").length, 1,
>       "There should be 2 variables displayed in the global scope");

Fix the test message?

>+    is(innerScope.querySelectorAll(".variables-view-property:not([non-match])").length, 7,
>       "There should be 8 properties displayed in the inner scope");

And here.  Do we understand why these were needed?

r=me with that.

Comment 4

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2245b038bcc

Comment 5

[(no longer active)]

Backed out because of browser-chrome test failures: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=a2245b038bcc

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b63238518a3

Comment 6

[Boris Zbarsky [:bzbarsky]]

Looks like the debugger tests no longer need some of the changes from this bug (the [object Proxy] bit because jimb fixed that bustage, and not sure about the rest).

I took out those parts of the patch, verified that the tests that failed when this was pushed now pass for me locally, and pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/adaaf6641785

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/adaaf6641785