85602 - FindContentForDocShell walks entire content tree

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Brian Ryner (not reading)]

nsEventStateManager::FindContentForDocShell walks the entire content tree to 
find the content mapped to the given docshell.  I propose that a much faster 
way to do this would be to walk the list of content nodes that have mapped 
subshells, since this will generally be a much smaller list.

This functionality should be done in the PresShell so we don't have to make 
mSubShellMap public.  Looking at the interface of the nsDST object used to hold 
this map, it provides an Iterate() method that we can use to look at all of the 
content nodes with subshells.  This works by calling the nsDSTNodeFunctor 
object you pass to Enumerate repeatedly with each key in the table.

I'd also propose, for efficiency, that we modify the nsDSTNodeFunctor so that 
we can return a boolean value of whether to continue iterating.

Comment 1

[rbs]

http://lxr.mozilla.org/seamonkey/search?string=FindContentForDocShell

Comment 2

[rods (gone)]

Tomorrow is my last day until Aug 13, I don't think you want to assign this bug 
to me, I probably won't get to it until the end of Aug, if then.

Comment 3

[Blu3]

p.s.  <jag> at #mozilla also saw this affect and I don't know exactly what build
he is using.

Comment 4

[Brian Ryner (not reading)]

talked with jst about how we can fix this... taking for 0.9.6.

Comment 5

[Aaron Leventhal]

It's the "outer" content node that we're looking for here.
For example, the <browser> or <iframe> content node from the parent docshell's
document.

Is there any reason the docshell can't keep track of this?

Comment 6

[Brian Ryner (not reading)]

fixed

Comment 7

[sairuh (rarely reading bugmail)]

rs vrfy