104977 - Tracking bug for document tabbing rewrite

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Brian Ryner (not reading)]

This bug is for tracking the document tabbing rewrite.  I'll be marking bugs
dependent on this that the rewrite will fix.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch v1.0

Comment 2

[Brian Ryner (not reading)]

Attachment: patch v2.0

Comment 3

[sairuh (rarely reading bugmail)]

interesting observation seen with patch v2:

go to a page with *no* focusable content with a small amount of content that
requires no scrolling. eg, an attachment page with a short patch. i have a
sample at http://hopey.mcom.com/tests/nothing-focusable.html

observe: when you tab into the content area, the focus ring *persists* --whether
you click with the mouse, or if use the keyboard to 'scroll' [cannot, of course,
but try hitting space, arrow keys or PgUp/PgDn].

true this is an edge-case --not sure what we should do here: keep the focus ring
anyhow when we mouse-click, or not?

side note: if the page is scrollable [compare with
http://hopey.mcom.com/tests/nothing-focusable-scroll.html], the focus ring still
persists w/mouse-clicks --but not with keyboard scrolling. [the latter is
expected, of course.]

Comment 4

[sairuh (rarely reading bugmail)]

using builds with patch v2.0 [all platforms]:

1. load viewer test #9.
2. open a tab.
3. go back to the tab with viewer #9.
4. ctrl+tab btwn the frames

observation: you'll encounter a 'dead spot' btwn the last frame and the URL bar.

moreover, with additional tabs, you get additional dead spots. eg, open a 3rd
tab, go back to viewer #9, and you encounter 2 dead spots btwn the last frame
and the URL bar.

Comment 5

[sairuh (rarely reading bugmail)]

addenda to my 2001-10-18 17:38 comments:

* also occurs with [shift]+F6
* further compounded if another tab contains frames [a dead spot is added per
frame].

Comment 6

[sairuh (rarely reading bugmail)]

Attachment: interesting results using ctrl+[shift]+tab and [shift]+F6

Comment 7

[Brian Ryner (not reading)]

Attachment: patch v2.1

Comment 8

[David Hyatt]

handleCtrlTab should be a boolean property, not a string property.  Make the
getter/setter return true/false, and then the calling code will be much simpler.

Comment 9

[Brian Ryner (not reading)]

checked in.  Bug 106123 filed on the issue of focusing hidden panels in tabbrowser.

Comment 10

[sairuh (rarely reading bugmail)]

vrfy fixed using commericial bits over the last week.

new/seperate bugs have been/should be filed, well, seperately. ;)