Closed
Bug 856151
Opened 13 years ago
Closed 13 years ago
Use of client coordinates in various modules need to be translated to browser coordinates
Categories
(Firefox for Metro Graveyard :: Input, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: jimm, Assigned: jimm)
References
Details
Attachments
(3 files, 7 obsolete files)
|
10.88 KB,
patch
|
fryn
:
review+
|
Details | Diff | Splinter Review |
|
16.71 KB,
patch
|
Details | Diff | Splinter Review | |
|
11.00 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
We use clientX and clientY quite a bit but this is incorrect, we should be translating these according to the position of the <browser> or the deck the browsers sit in.
| Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → jmathies
| Assignee | ||
Comment 2•13 years ago
|
||
Attachment #731653 -
Attachment is obsolete: true
| Assignee | ||
Comment 3•13 years ago
|
||
Attachment #731654 -
Attachment is obsolete: true
| Assignee | ||
Comment 4•13 years ago
|
||
| Assignee | ||
Comment 5•13 years ago
|
||
I'll add more to these as I go, this is start.
Attachment #731822 -
Attachment is obsolete: true
Attachment #731834 -
Attachment is obsolete: true
Attachment #731877 -
Flags: review?(mbrubeck)
| Assignee | ||
Comment 6•13 years ago
|
||
This fixes up context menu positioning when the browser position shifts. I've also added a test.
Attachment #731878 -
Flags: review?(fyan)
Comment 7•13 years ago
|
||
Comment on attachment 731877 [details] [diff] [review]
bindings
Review of attachment 731877 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/metro/base/content/bindings/browser.xml
@@ +203,5 @@
> +
> + return {
> + xPos: (aBrowserX * scale - scrollX - deckX + bcr.left),
> + yPos: (aBrowserY * scale - scrollY - deckY + bcr.top)
> + };
Nit: I'd like to continue using {x, y} instead of {xPos, yPos}.
The main rationale is that we can then use these return values together with "Point" instances and methods from Geometry.jsm.
Attachment #731877 -
Flags: review?(mbrubeck) → review+
| Assignee | ||
Comment 8•13 years ago
|
||
updated per comments. I've also added some new helpers for converting individual points which I'm using in selection code.
Attachment #731877 -
Attachment is obsolete: true
| Assignee | ||
Comment 9•13 years ago
|
||
updated a couple xPos -> x type comments in the header.
Attachment #731993 -
Attachment is obsolete: true
Comment 10•13 years ago
|
||
Comment on attachment 731997 [details] [diff] [review]
bindings
Review of attachment 731997 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/metro/base/content/helperui/SelectHelperUI.js
@@ +108,5 @@
>
> return {
> forcePosition: true,
> + xPos: p0.xPos,
> + yPos: p1.yPos,
This needs to be updated to .x and .y too.
Comment 11•13 years ago
|
||
Comment on attachment 731878 [details] [diff] [review]
context menu fix
Review of attachment 731878 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
::: browser/metro/base/content/helperui/MenuUI.js
@@ +194,3 @@
> this._menuPopup.show(Util.extend({}, this._defaultPositionOptions, {
> + xPos: coords.xPos,
> + yPos: coords.yPos,
This needs to be updated to .x and .y.
Attachment #731878 -
Flags: review?(fyan) → review+
| Assignee | ||
Comment 12•13 years ago
|
||
| Assignee | ||
Comment 13•13 years ago
|
||
This passes all of my selection tests I have in my queue (amazing!).
Attachment #732005 -
Attachment is obsolete: true
Attachment #732034 -
Flags: review?(mbrubeck)
Updated•13 years ago
|
Attachment #732034 -
Flags: review?(mbrubeck) → review+
Comment 14•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a5aa2d31e8e9
https://hg.mozilla.org/mozilla-central/rev/5722966a3126
https://hg.mozilla.org/mozilla-central/rev/d3a0bc6f68b1
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Updated•12 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•