859447 - Defect - Nothing happens when I tap the settings icon in the page info bar

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P1)

Description

[juan becerra [:juanb]]

Tested on 2013-04-08 using a Nightly built from http://hg.mozilla.org/mozilla-central/rev/b0d842380959

While verifying bug 841228 I noticed that the settings icon wasn't doing anything when tapped. Usually things brings up the "find in page" option.

Steps:
1. Visit any page
2. Bring up the page info bar swiping up from the bottom.
3. Click on the settings icon

Expected: You should see the "find in page" options

Actual: Nothing happens.

A build from last week worked.

Comment 1

[Brian R. Bondy [:bbondy]]

Jim I think this is bug 844370

Comment 2

[Brian R. Bondy [:bbondy]]

Console has this message:
menuUI.js line 194: aMessage.target is undefined

Comment 3

[Jim Mathies [:jimm]]

Attachment: fix

Comment 4

[Jim Mathies [:jimm]]

This is called from here - 

http://mxr.mozilla.org/mozilla-central/source/browser/metro/base/content/appbar.js#109

I need to file a bug about de-jsonifying MenuUI apis.

Comment 5

[Marco Mucci [:MarcoM]]

Hey Jim, would you like this added to Iteration #5?  If so, let me know a point estimate.

Comment 6

[Jim Mathies [:jimm]]

(In reply to Marco Mucci [:MarcoM] from comment #5)
> Hey Jim, would you like this added to Iteration #5?  If so, let me know a
> point estimate.

Sure, it already has a fix.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a64adac42aa0

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
> https://hg.mozilla.org/mozilla-central/rev/a64adac42aa0

This patch is empty.

Comment 9

[Jim Mathies [:jimm]]

(In reply to :Ms2ger from comment #8)
> (In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
> > https://hg.mozilla.org/mozilla-central/rev/a64adac42aa0
> 
> This patch is empty.

Oops. doesn't look like it got merged into another patch either.

Comment 10

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d954dd75a61b

Thanks for catching that Ms2ger!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d954dd75a61b

Comment 12

[Marco Mucci [:MarcoM]]

For Kamil to test and verify.

Comment 13

[Kamil Jozwiak [:kjozwiak]]

Went through the "Defect" and everything passed without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-20-03-10-10-mozilla-central/

Went through the following test cases:

- Swipping in the "Info App Bar" from the bottom and ensured that the "Settings" icon worked without any issues (awesome screen & other web pages)
- Swipping in the "Info App Bar" from the top and ensured that the "Settings" icon worked without any issues (awesome screen & other web pages)
- Selecting the "Info App Bar" using "CTRL + Z" and ensured that the "Settings" icon worked without any issues (awesome screen & other web pages)
- Ensured that selecting the "Settings" icon on the awesome sreen showed the appropriate selections (Find in page)
- Ensured that selecting the "Settings" icon on other web pages showed the appropriate selections (Find in page & View on desktop)
- Ensured that the "Settings" icon still worked after swipping in the "Options" charm
- Ensured that all of the above cases also worked while the browser is in Filled View

Comment 14

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Verified for it8

Comment 15

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #9 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-06-27-03-10-27-mozilla-central/

- Went through the added test cases in comment 13 without any issues

Comment 16

[juan becerra [:juanb]]

Went through this for iteration #10 and filed bug 898651 for a defect/change related to the "Find in page" option when in the start page.

Comment 17

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130807030216
Built from http://hg.mozilla.org/mozilla-central/rev/1fb5d14e8348

WFM
Tested on windows 8 using latest nightly  for iteration-11. Followed steps provided in comment0 and got expected result.

Comment 18

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130826074752
Built from http://hg.mozilla.org/mozilla-central/rev/14b1e8c2957e

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result.