856283 - Saved password overlapping with other text in the "Password" field

Status: RESOLVED WORKSFORME

(Firefox for Metro Graveyard :: Input, defect)

Description

[Kamil Jozwiak [:kjozwiak]]

When a saved password is inserted into a text box that has some text already inside it, the  password will overlap the text. Twitter is a perfect example, the password field has the word "Password" in it, and when filled with the saved password, the two overlap.

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go to twitter.com
3) Login into your Twitter account and select "Remember Password" at the top
4) Log out from Twitter and close Firefox Metro
5) Repeat Step #1 & #2
6) Insert the same account name as before (if its filled out already, remove it and the password)
7) Once you have inserted the account name, select the "Password" field (You will notice that the saved password is overlapping with the "Password" text in the field)

Current Behavior:

- The saved password is pasted into the field and overlaps with the text that is already present in the "Password" field

Expected Behavior:

- The "Password" field is cleared, and then the saved password is inserted into the field without any overlaps

Comment 1

[Kamil Jozwiak [:kjozwiak]]

consideration for iteration #6

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Overlapping password field

Comment 3

[Brian R. Bondy [:bbondy]]

p=3

Comment 4

[Sam Foster [:sfoster] (he/him)]

At least in the case of the twitter.com login, they aren't using the the placeholder attribute, they are positioning a label over the input and relying on focus events to remove their faux-placeholder. Desktop fx seems to have the same "defect". Chrome seems to manage to do the right thing here. I took a peek at the code but without digging further  - and knowing more about how our saved password inject works I'm not sure what needs to happn here.

Comment 5

[Brian R. Bondy [:bbondy]]

Kamil can you also reproduce in Desktop? If so I think we should punt this to v2.

Comment 6

[Kamil Jozwiak [:kjozwiak]]

Brian, went through the latest Nightly and could reproduce the same issue on Firefox Desktop & Firefox Metro, used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-29-03-09-26-mozilla-central/

Comment 7

[Brian R. Bondy [:bbondy]]

v2 since it is a desktop and metro problem as Sam found and Kamil verified?
Or maybe untrack from Metro work?

Comment 8

[Jim Mathies [:jimm]]

also exists on desktop.

Comment 9

[Kamil Jozwiak [:kjozwiak]]

Went through the following defect for iteration #20 without any issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013/03/2013-03-25-03-11-00-mozilla-central/

I can't reproduce this issue any more.. Tried several times with different websites on both Firefox Desktop and Firefox Metro (Nightly build listed above)

- Went through the original test case in comment #0 without any issues
- Logged into Twitter, Gmail, LinkedIn, Facebook, Digital Ocean (saved the username & password) and then ensured that the username/password were not placed on top of the pre-filled text in both the username & password fields
- Went through all of the above test cases in Desktop/Metro environments without any issues

Comment 10

[Kamil Jozwiak [:kjozwiak]]

Pasted the incorrect build into the above ticket (was trying to reproduce an older issue). The above test cases used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-12-23-03-02-03-mozilla-central/