856351 - Paris binding for DragEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=017aeb48a985

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Please remove the quickstubs

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 731539 [details] [diff] [review]
patch

Review of attachment 731539 [details] [diff] [review]:
-----------------------------------------------------------------

Remove the quickstubs please.

::: content/events/src/nsDOMDragEvent.h
@@ +36,5 @@
> +  void InitDragEvent(const nsAString& aType,
> +                     bool aCanBubble, bool aCancelable,
> +                     nsIDOMWindow* aView, int32_t aDetail,
> +                     int32_t aScreenX, int32_t aScreenY,
> +                     int32_t aClientX, int32_t aClientY, 

Trailing whitespace.

Comment 3

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

Crap, the tryserver didn't look good and I had pushed to try when m-i wasn't in
good shape.
Trying again https://tbpl.mozilla.org/?tree=Try&rev=7cb5b5fe7b12

Comment 4

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

Attachment: notflattened=True for DataTransfer

It is so easy to forget notflattened

Comment 5

[Olli Pettay [:smaug][[e-mail]](vacation until Nov 16)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b5381804b7c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4b5381804b7c