856364 - Paris binding for KeyboardEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=94a664393211

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 731588 [details] [diff] [review]
patch

Review of attachment 731588 [details] [diff] [review]:
-----------------------------------------------------------------

Please remove the quickstubs

::: content/events/src/nsDOMKeyboardEvent.h
@@ +57,5 @@
> +  }
> +
> +  uint32_t CharCode();
> +  uint32_t KeyCode();
> +  virtual uint32_t Which();

MOZ_OVERRIDE

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 731588 [details] [diff] [review]
patch

Review of attachment 731588 [details] [diff] [review]:
-----------------------------------------------------------------

Please remove the quickstubs.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: up-to-date

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e455dcbe23fd

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e455dcbe23fd