856373 - WebIDL-ify Gamepad events

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(not currently active) Ted Mielczarek]

This is harder than just changing the Gamepad interface to WebIDL because it relies on WebIDL for generated events, bug 847611.

Comment 1

[(not currently active) Ted Mielczarek]

bug 847611 added .webidl versions of the event interfaces, but the xpidl ones still exist for the time being.

Comment 2

[David Zbarsky (:dzbarsky)]

Attachment: gamepadevents

We're still generating some unnecessary boilerplate for derived events, but it's probably not worth complicating the code to avoid.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Could you upload also the generated files.
They are in <objdir>/dom/bindings/<YourEvent>.[h|cpp]

Comment 4

[David Zbarsky (:dzbarsky)]

Attachment: GamepadButtonEvent.h

Comment 5

[David Zbarsky (:dzbarsky)]

Attachment: GamepadButtonEvent.cpp

Comment 6

[(not currently active) Ted Mielczarek]

I believe the events were the only things keeping nsIDOMGamepad.idl alive as well, since the API was converted to WebIDL.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 803167 [details] [diff] [review]
gamepadevents

I guess just including config.getDescriptor(parent, False).headerFile should work, and nsDOMEvent.h can be dropped.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 803167 [details] [diff] [review]
gamepadevents

Er, wait

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

The patch doesn't initialize members in the parent.

Comment 10

[David Zbarsky (:dzbarsky)]

Attachment: Init parent members

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 803197 [details] [diff] [review]
Init parent members

Yeah, this should do it. Tiny bit duplication in the generated code, but ok.
Make sure to check the generated code, also that nsDOMEvent is included when needed (though the code just shouldn't compile if it is missing)

Comment 12

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2494c41c421f

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2494c41c421f