856424 - Unpref Components for content

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

Now that bug 790732 has landed, the Components object is no longer defined in content scopes. However, this behavior is behind a pref, and we may end up needing to flip that pref on aurora or beta for web compat.

Once this pref makes it all the way to release, we can remove it, which will pave the way for a lot of important refactoring and simplification.

Comment 1

[Alex Keybl [:akeybl]]

Any call on whether we'll want to do this for FF22?

Comment 2

[Benjamin Smedberg]

If we remove the pref code, I think that can ride the trains, so I wouldn't take this in 22 anyway.

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 4

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=ea16e1e37357

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 791839 [details] [diff] [review]
patch

test_sandbox.xul failed.

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: patch v2

Resolved the test failure.

Comment 7

[Bobby Holley (:bholley)]

Comment on attachment 792230 [details] [diff] [review]
patch v2

Review of attachment 792230 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, this is awesome! Thanks a ton for the patch. r=bholley

Comment 8

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af93c819008e

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af93c819008e

Comment 10

[Masatoshi Kimura [:emk]]

Components-in-content was already disabled by flipping the pref since Firefox 22. This bug just removed the flipped pref. Also, I couldn't find any documents explaining about thedom.omit_components_in_content pref (including Firefox 22 compatibility docs).
So I don't think we need to update documents.