Closed Bug 856424 Opened 7 years ago Closed 7 years ago

Unpref Components for content

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26
Tracking Status
firefox22 - ---

People

(Reporter: bholley, Assigned: emk)

References

Details

Attachments

(1 file, 1 obsolete file)

Now that bug 790732 has landed, the Components object is no longer defined in content scopes. However, this behavior is behind a pref, and we may end up needing to flip that pref on aurora or beta for web compat.

Once this pref makes it all the way to release, we can remove it, which will pave the way for a lot of important refactoring and simplification.
Blocks: 693733
Blocks: 794943
Blocks: 856437
No longer blocks: 693733
Any call on whether we'll want to do this for FF22?
If we remove the pref code, I think that can ride the trains, so I wouldn't take this in 22 anyway.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #791839 - Flags: review?(bobbyholley+bmo)
Comment on attachment 791839 [details] [diff] [review]
patch

test_sandbox.xul failed.
Attachment #791839 - Flags: review?(bobbyholley+bmo)
Attached patch patch v2Splinter Review
Resolved the test failure.
Attachment #791839 - Attachment is obsolete: true
Attachment #792230 - Flags: review?(bobbyholley+bmo)
Comment on attachment 792230 [details] [diff] [review]
patch v2

Review of attachment 792230 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, this is awesome! Thanks a ton for the patch. r=bholley
Attachment #792230 - Flags: review?(bobbyholley+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/af93c819008e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Components-in-content was already disabled by flipping the pref since Firefox 22. This bug just removed the flipped pref. Also, I couldn't find any documents explaining about thedom.omit_components_in_content pref (including Firefox 22 compatibility docs).
So I don't think we need to update documents.
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.