856437 - Remove Components.lookupMethod

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Isn't this just a dupe of bug 693733 now?

Comment 2

[Andrew McCreight [:mccr8]]

Ah I was too quick to post. :)

Comment 3

[Bobby Holley (:bholley)]

Components is no longer available to the web. XBL runs in its own scope now, and gets Xray vision to content (just like chrome). This function no longer serves any purpose, and can go away.

Patches coming up.

Comment 4

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=7a1039204eef

Comment 5

[Tom S [:evilpie]]

Some addons use it, especially Flashblock, which is rather popular.

Comment 6

[Bobby Holley (:bholley)]

(In reply to Tom Schuster [:evilpie] from comment #5)
> Some addons use it, especially Flashblock, which is rather popular.

Yes, but they don't need to anymore. Flashblock uses in-content XBL controls, which now run in XBL scopes and have Xray vision, meaning that the lookupMethod behavior happens automatically.

Comment 7

[Bobby Holley (:bholley)]

/me facepalms after revving nsIXPCComponents and nsIXPCComponents_Utils to the same UUID.

https://tbpl.mozilla.org/?tree=Try&rev=758d3fd66ddb

Comment 8

[Bobby Holley (:bholley)]

Green modulo one test that I've fixed. Uploading patches and flagging for review.

Comment 9

[Bobby Holley (:bholley)]

Attachment: Part 1 - Remove LookupMethod test coverage. v1

Comment 10

[Bobby Holley (:bholley)]

Attachment: Part 2 - Remove lookupMethod API. v1

Comment 11

[Bobby Holley (:bholley)]

Attachment: Part 3 - Remove same-compartment permissive Xray machinery. v1

Comment 12

[Gabor Krizsanits (INACTIVE)]

(In reply to Bobby Holley (:bholley) from comment #6)
> (In reply to Tom Schuster [:evilpie] from comment #5)
> > Some addons use it
> 
> Yes, but they don't need to anymore.

Could you please make sure that someone writes a few lines about this change at http://blog.mozilla.org/addons/ ? So when add-on owners find their add-ons to be broken, they can figure out quickly why lookupMethod isn't there any longer and how should they fix their add-ons?

Other than that I'm really happy to see this method die :)

Comment 13

[Bobby Holley (:bholley)]

NeedInfo jorge per comment 12.

Comment 14

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f15dd36f13bf
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b8d0c4f36127
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/add6b8c0a28f

Comment 15

[Jorge Villalobos [:jorgev] (he/him)]

Setting the addon-compat flag and then setting the right Milestone one this lands is sufficient. Thanks :)

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f15dd36f13bf
https://hg.mozilla.org/mozilla-central/rev/b8d0c4f36127
https://hg.mozilla.org/mozilla-central/rev/add6b8c0a28f