Closed Bug 856437 Opened 7 years ago Closed 6 years ago

Remove Components.lookupMethod

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: jruderman, Assigned: bholley)

References

Details

(Keywords: addon-compat)

Attachments

(3 files)

No description provided.
Isn't this just a dupe of bug 693733 now?
Ah I was too quick to post. :)
Components is no longer available to the web. XBL runs in its own scope now, and gets Xray vision to content (just like chrome). This function no longer serves any purpose, and can go away.

Patches coming up.
Some addons use it, especially Flashblock, which is rather popular.
(In reply to Tom Schuster [:evilpie] from comment #5)
> Some addons use it, especially Flashblock, which is rather popular.

Yes, but they don't need to anymore. Flashblock uses in-content XBL controls, which now run in XBL scopes and have Xray vision, meaning that the lookupMethod behavior happens automatically.
/me facepalms after revving nsIXPCComponents and nsIXPCComponents_Utils to the same UUID.

https://tbpl.mozilla.org/?tree=Try&rev=758d3fd66ddb
Green modulo one test that I've fixed. Uploading patches and flagging for review.
Attachment #802527 - Flags: review?(gkrizsanits)
Attachment #802528 - Flags: review?(gkrizsanits)
(In reply to Bobby Holley (:bholley) from comment #6)
> (In reply to Tom Schuster [:evilpie] from comment #5)
> > Some addons use it
> 
> Yes, but they don't need to anymore.

Could you please make sure that someone writes a few lines about this change at http://blog.mozilla.org/addons/ ? So when add-on owners find their add-ons to be broken, they can figure out quickly why lookupMethod isn't there any longer and how should they fix their add-ons?

Other than that I'm really happy to see this method die :)
Attachment #802527 - Flags: review?(gkrizsanits) → review+
Attachment #802528 - Flags: review?(gkrizsanits) → review+
Attachment #802529 - Flags: review?(gkrizsanits) → review+
NeedInfo jorge per comment 12.
Flags: needinfo?(jorge)
Setting the addon-compat flag and then setting the right Milestone one this lands is sufficient. Thanks :)
Flags: needinfo?(jorge)
https://hg.mozilla.org/mozilla-central/rev/f15dd36f13bf
https://hg.mozilla.org/mozilla-central/rev/b8d0c4f36127
https://hg.mozilla.org/mozilla-central/rev/add6b8c0a28f
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Assignee: nobody → bobbyholley+bmo
You need to log in before you can comment on or make changes to this bug.