Last Comment Bug 856478 - remove nsISupportsArray from mailnews/extensions/mailviews/src/nsMsgMailViewList.cpp
: remove nsISupportsArray from mailnews/extensions/mailviews/src/nsMsgMailViewL...
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Search (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 23.0
Assigned To: :aceman
:
Mentors:
Depends on:
Blocks: 394167
  Show dependency treegraph
 
Reported: 2013-03-31 16:02 PDT by :aceman
Modified: 2013-04-03 05:03 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (6.93 KB, patch)
2013-03-31 16:35 PDT, :aceman
no flags Details | Diff | Splinter Review
patch v2 (6.92 KB, patch)
2013-04-02 12:18 PDT, :aceman
neil: review+
Details | Diff | Splinter Review
patch v3 (6.89 KB, patch)
2013-04-02 13:54 PDT, :aceman
acelists: review+
Details | Diff | Splinter Review

Description :aceman 2013-03-31 16:02:38 PDT
Defined as a variable in:

    mailnews/extensions/mailviews/src/nsMsgMailViewList.cpp (View Hg log or Hg annotations)
        line 139 -- m_mailViews->Count(aCount);
        line 151 -- m_mailViews->Count(&mailViewCount);
        line 154 -- return m_mailViews->QueryElementAt(aMailViewIndex, NS_GET_IID(nsIMsgMailView),
        line 163 -- m_mailViews->AppendElement(static_cast<nsISupports*>(aMailView));
        line 172 -- m_mailViews->RemoveElement(static_cast<nsISupports*>(aMailView));
        line 213 -- m_mailViews->Count(&mailViewCount); 
    mailnews/extensions/mailviews/src/nsMsgMailViewList.h (View Hg log or Hg annotations)
        line 49 -- nsCOMPtr<nsISupportsArray> m_mailViews; 

Referenced in:

    mailnews/extensions/mailviews/src/nsMsgMailViewList.cpp (View Hg log or Hg annotations)
        line 138 -- if (m_mailViews)
        line 148 -- NS_ENSURE_TRUE(m_mailViews, NS_ERROR_FAILURE);
        line 161 -- NS_ENSURE_TRUE(m_mailViews, NS_ERROR_FAILURE);
        line 170 -- NS_ENSURE_TRUE(m_mailViews, NS_ERROR_FAILURE);
        line 212 -- if (m_mailViews)
        line 274 -- ConvertFilterListToMailView(mFilterList, getter_AddRefs(m_mailViews));
Comment 1 :aceman 2013-03-31 16:35:04 PDT
Created attachment 731722 [details] [diff] [review]
patch
Comment 2 neil@parkwaycc.co.uk 2013-04-01 16:21:48 PDT
Comment on attachment 731722 [details] [diff] [review]
patch

>     // now convert the filter list into our mail view objects, stripping out just the info we need
>-    ConvertFilterListToMailView(mFilterList, getter_AddRefs(m_mailViews));
>+    ConvertFilterListToMailView(mFilterList, &m_mailViews);
If this is the only caller, then we shouldn't be passing members (compare ConvertMailViewListToFilterList). [Failing that, my preference would have been to pass the nsCOMArray by reference.]
Comment 3 :aceman 2013-04-02 12:18:27 PDT
Created attachment 732464 [details] [diff] [review]
patch v2

Thanks.
Comment 4 neil@parkwaycc.co.uk 2013-04-02 13:37:15 PDT
Comment on attachment 732464 [details] [diff] [review]
patch v2

[aFilterList could have become mFilterList too]
Comment 5 :aceman 2013-04-02 13:54:18 PDT
Created attachment 732506 [details] [diff] [review]
patch v3

OK, done.
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-04-03 05:03:55 PDT
https://hg.mozilla.org/comm-central/rev/bbdfb610ba02

Note You need to log in before you can comment on or make changes to this bug.