856478 - remove nsISupportsArray from mailnews/extensions/mailviews/src/nsMsgMailViewList.cpp

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[:aceman]

Defined as a variable in:

    mailnews/extensions/mailviews/src/nsMsgMailViewList.cpp (View Hg log or Hg annotations)
        line 139 -- m_mailViews->Count(aCount);
        line 151 -- m_mailViews->Count(&mailViewCount);
        line 154 -- return m_mailViews->QueryElementAt(aMailViewIndex, NS_GET_IID(nsIMsgMailView),
        line 163 -- m_mailViews->AppendElement(static_cast<nsISupports*>(aMailView));
        line 172 -- m_mailViews->RemoveElement(static_cast<nsISupports*>(aMailView));
        line 213 -- m_mailViews->Count(&mailViewCount); 
    mailnews/extensions/mailviews/src/nsMsgMailViewList.h (View Hg log or Hg annotations)
        line 49 -- nsCOMPtr<nsISupportsArray> m_mailViews; 

Referenced in:

    mailnews/extensions/mailviews/src/nsMsgMailViewList.cpp (View Hg log or Hg annotations)
        line 138 -- if (m_mailViews)
        line 148 -- NS_ENSURE_TRUE(m_mailViews, NS_ERROR_FAILURE);
        line 161 -- NS_ENSURE_TRUE(m_mailViews, NS_ERROR_FAILURE);
        line 170 -- NS_ENSURE_TRUE(m_mailViews, NS_ERROR_FAILURE);
        line 212 -- if (m_mailViews)
        line 274 -- ConvertFilterListToMailView(mFilterList, getter_AddRefs(m_mailViews));

Comment 1

[:aceman]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 731722 [details] [diff] [review]
patch

>     // now convert the filter list into our mail view objects, stripping out just the info we need
>-    ConvertFilterListToMailView(mFilterList, getter_AddRefs(m_mailViews));
>+    ConvertFilterListToMailView(mFilterList, &m_mailViews);
If this is the only caller, then we shouldn't be passing members (compare ConvertMailViewListToFilterList). [Failing that, my preference would have been to pass the nsCOMArray by reference.]

Comment 3

[:aceman]

Attachment: patch v2

Thanks.

Comment 4

[[e-mail]]

Comment on attachment 732464 [details] [diff] [review]
patch v2

[aFilterList could have become mFilterList too]

Comment 5

[:aceman]

Attachment: patch v3

OK, done.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/bbdfb610ba02