Closed Bug 856495 Opened 7 years ago Closed 7 years ago

exception using push notifications on desktop - mozilla.org/network/manager;1 not defined

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(1 file)

* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "Cc['@mozilla.org/network/manager;1'] is undefined" {file: "file:///Users/dougt/builds/b2g_build/dist/B2GDebug.app/Contents/MacOS/components/P\
ushService.js" line: 1247}]' when calling method: [nsIWebSocketListener::onStart]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame \
:: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
Attached patch patch v.1Splinter Review
Attachment #731737 - Flags: review?(nsm.nikhil)
Code looks good but since bug 856440 disables push on fx desktop, lets keep this code simple for now.
Component: DOM: Other → DOM
Comment on attachment 731737 [details] [diff] [review]
patch v.1

We'll need this for bug 857464.  Lets just land it and get it out of our patch queue.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f511f109d4e9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
per b2g meeting just now, and yesterday's b2g-dev meeting: 

Currently, to support external v1.1 app developers, myk is required to manually generate a second, separate build, identical except for this additional patch. If this patch is landed on b2g-18, then these simulator builds can be generated automatically by RelEng. 

How does he request approval to uplift this patch to v1-train?
Flags: needinfo?(praghunath)
Flags: needinfo?(lsblakk)
Flags: needinfo?(akeybl)
this doesn't need to be uplifted.
Flags: needinfo?(praghunath)
Flags: needinfo?(lsblakk)
Flags: needinfo?(akeybl)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.