856495 - exception using push notifications on desktop - mozilla.org/network/manager;1 not defined

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Doug Turner (:dougt)]

* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "Cc['@mozilla.org/network/manager;1'] is undefined" {file: "file:///Users/dougt/builds/b2g_build/dist/B2GDebug.app/Contents/MacOS/components/P\
ushService.js" line: 1247}]' when calling method: [nsIWebSocketListener::onStart]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame \
:: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Code looks good but since bug 856440 disables push on fx desktop, lets keep this code simple for now.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 731737 [details] [diff] [review]
patch v.1

We'll need this for bug 857464.  Lets just land it and get it out of our patch queue.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f511f109d4e9

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f511f109d4e9

Comment 6

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

per b2g meeting just now, and yesterday's b2g-dev meeting: 

Currently, to support external v1.1 app developers, myk is required to manually generate a second, separate build, identical except for this additional patch. If this patch is landed on b2g-18, then these simulator builds can be generated automatically by RelEng. 

How does he request approval to uplift this patch to v1-train?

Comment 7

[Doug Turner (:dougt)]

this doesn't need to be uplifted.