856543 - [Buri][UI][LOCK] wake-up display response very slow if setting a SD card picture as wallpaper

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect, P2)

Description

[sync-1]

+++ This bug was initially created as a clone of Bug #432198 +++
 
 From the Gallery application, set a picture as wallpaper. The picture needs to be large large enough (~ 2 Mb) for the bug to be obvious.
 
 With such wallpaper, everytime the user switches-on the backlight there is a black screen during half a second or more, before the wallpaper is actually displayed.
 
 Note that this issue doesn't happen when the wallpaper is set from the Homescreen application !
 
 The difference between both cases is that setting the wallpaper from the Homescreen seems to rescale and crop the image, whereas the full image is kept when setting the wallpaper from the Gallery. This explains the additional processing time in the latter case.
 
 
 Expected behavior: 
 The handset shall be as responsive as possible for a simple action such as switching the backlight on, and there shall be no transcient screen before the wallpaper is displayed. We suggest to store the croppped and scaled-down version of the wallpaper in every case.
 
 
 
 
 DEFECT DESCRIPTION:
 
 REPRODUCING PROCEDURES:
 
 EXPECTED BEHAVIOUR:
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 
 REPRODUCING RATE:
 
 For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #432198 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[buri.blff]

Attachment: picture sample

Comment 2

[Daniel Coloma:dcoloma]

>  
>  Note that this issue doesn't happen when the wallpaper is set from the
> Homescreen application !
>  
>  The difference between both cases is that setting the wallpaper from the
> Homescreen seems to rescale and crop the image, whereas the full image is
> kept when setting the wallpaper from the Gallery. This explains the
> additional processing time in the latter case.
>  

David, could we do the same with the background when selected from the gallery?

Comment 3

[David Flanagan [:djf]]

Gallery resizes images when they are picked.

This bug is about the share activity. 

Gallery can't resize an image it is going to share because it doesn't know who it will be sharing with.

So the responsibility here is the wallpaper app that handles the share.  It should resize the image.  (And I'm actually surprised that it doesn't already.)

Comment 4

[David Flanagan [:djf]]

See also 833738. The fix for this bug should fix that one as well, and if it does, please close both.

Comment 5

[Andrew Overholt [:overholt]]

How are things going here?

Comment 6

[Michał Budzyński (:michalbe)]

Attachment: patch

Comment 7

[Michał Budzyński (:michalbe)]

This is also a fix for #833738.

Comment 8

[David Flanagan [:djf]]

Comment on attachment 736102 [details]
patch

Michal: I think the math you use for cropping the image does not work for images with unusual aspect ratios.  Please see my comments on github, which include a reference to Gallery code that does this same kind of resizing.  I think you can find a good working example there.


Sorry this review took so long. Feel free to remind me next time that this is a TEF+ bug and I'll review more quickly!

Comment 9

[Anthony Ricaud (:rik)]

Stealing this as Michal is on holidays.

Comment 10

[Anthony Ricaud (:rik)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9230

Pointer to Github pull-request

Comment 11

[Anthony Ricaud (:rik)]

Comment on attachment 738410 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9230

Redirecting the review to a european based reviewer.

Comment 12

[Dale Harvey (:daleharvey)]

Comment on attachment 738410 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9230

Sorry for the delay, its working great, vivien has some comments in there as well as me, since addressing Viviens means a bit of a change ill clear the review and retest etc asap when the follow up patch comes

Comment 13

[Dale Harvey (:daleharvey)]

Comment on attachment 738410 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9230

Merged in: https://github.com/mozilla-b2g/gaia/commit/909cf502ada9de6f16443ef873d91f6b2b05c8fa

Forgot to remember to ask that the commit message be changed, but too late now, apologies

Comment 14

[Anthony Ricaud (:rik)]

Followup cause I broke the linter tests :(

Both needs uplifting.
https://github.com/mozilla-b2g/gaia/commit/d763a4d81be710ede9c5fc43482759f6c2d523e0

Comment 15

[James Lal [:lightsofapollo]]

Uplifted d763a4d81be710ede9c5fc43482759f6c2d523e0 to:
v1-train: 89e8d8e75bbd41e13c8da134daa289ba0ea89be8
v1.0.1: dea32b2268bdf0ac172f42ec52f29bc4d5a9eee4

Comment 16

[Jeni]

Verified issue fixed on 
Inari Build ID: 20130429070204
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/45aa5ba0ed53
Gaia: cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2

 and on 

Leo Build ID: 20130426070204
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6c2493de1441
Gaia: c9046a7acef33328977840176ff5574720d2c74c

When User sets a picture as wallpaper from the SD card the picture responds instantly