Closed Bug 856572 Opened 11 years ago Closed 11 years ago

Text is not black in selection popup

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox20 unaffected, firefox21 verified, firefox22 verified, firefox23 unaffected, fennec21+)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox20 --- unaffected
firefox21 --- verified
firefox22 --- verified
firefox23 --- unaffected
fennec 21+ ---

People

(Reporter: yoanna_crisan, Assigned: bnicholson)

References

Details

(Keywords: regression, Whiteboard: ui-hackathon)

Attachments

(3 files)

Screenshot with the bug
37.03 KB, image/png
Details
Screenshot of invisible checkbox
26.93 KB, image/png
Details
Fix popup dialog text
856 bytes, patch
mfinkle
: review+
bajaj
: approval-mozilla-aurora+
bajaj
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Firefox 22.0a1 31.03.2013
Samsung Galaxy R 2.3.4

Steps to reproduce:

1. Open Firefox 
2. Load the page www.bugzilla.mozilla.org
3. Tap the "Search" button
4. Click "Advanced Search"
5. Tap on the multiple selection combobox "Product"

Expected results:

Labels can be seen.

Actual results:

Labels can't be seen
Attached image Screenshot with the bug — 

    
    

    
  
I'm able to reproduce this on HTC Desire Z (Android 2.3.4) on Firefox for Android 22.0a1(2013-03-31) and Firefox for Android 21.0a2( 2013-03-31)
Status: UNCONFIRMED → NEW

          status-firefox20:
          --- → unaffected

          status-firefox21:
          --- → affected

          status-firefox22:
          --- → affected
Ever confirmed: true
Keywords: regression

    
    

    
  
Please find a regression range.
Component: Text Selection → General
Flags: needinfo?(teodora.vermesan)
Keywords: regressionwindow-wanted
Summary: Multiple selection pop-up issue → Text is not black in selection popup

    
    

    
  
The regression window for this issue is:
good build: 23.01.2013  
bad build:  24.01.2013 

possible pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2876e73c9b6f&tochange=98ea4d294369
The tinderbox inbound builds are missing since the issue is older than one month.
Flags: needinfo?(teodora.vermesan) → needinfo?
Keywords: regressionwindow-wanted
Flags: needinfo?
Blocks: 832321

    
    

    
  
This used to be fixed with the bug above.

    
    

    
  
I have also noticed the checkbox on alert dialogs is not visible. Screenshot coming.

    
    

    
  
(In reply to Mark Finkle (:mfinkle) from comment #7)
> Created attachment 732283 [details]
> Screenshot of invisible checkbox

This is on a Nexus S with Android 2.3.5

    
    

    
  
I'm confused how the bug was verified fixed yet it might be a regression from that bug that supposed to fix this in the first place?

    
    

    
  
This is still an issue on Firefox Mobile 21 beta 4 build 1 on the LG Optimus 2X (Android 2.2) but it is not reproducible on Nightly 23.0a1 2013-04-23
tracking-fennec: --- → ?

          status-firefox23:
          --- → unaffected

    
    

    
  
Brian - Can you look into why this is happening on beta, and maybe aurora?
Assignee: nobody → bnicholson

    
  
Whiteboard: ui-hackathon

    
    

    
  


  
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 832321
User impact if declined: can't see text in dialogs
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): low risk
String or IDL/UUID changes made by this patch: none

        Attachment #742613 -
        Flags: review?(wjohnston)

        Attachment #742613 -
        Flags: approval-mozilla-beta?

        Attachment #742613 -
        Flags: approval-mozilla-aurora?

    
  

        Attachment #742613 -
        Flags: review?(wjohnston) → review?(mark.finkle)

    
    

    
  
Comment on attachment 742613 [details] [diff] [review]
Fix popup dialog text

Does this cause any other regressions? Test, test, test.

        Attachment #742613 -
        Flags: review?(mark.finkle) → review+

        Attachment #742613 -
        Flags: approval-mozilla-beta?

        Attachment #742613 -
        Flags: approval-mozilla-beta+

        Attachment #742613 -
        Flags: approval-mozilla-aurora?

        Attachment #742613 -
        Flags: approval-mozilla-aurora+
Keywords: verifyme

    
    

    
  
Requesting QA verification once this lands.
Keywords: qawanted

    
    

    
  
Verified on Samsung Galaxy R 2.3.4 with Aurora(30.04.2013). I didn't see any issues in single choice, multiple choice and context menus.

          status-firefox22:
          fixed → verified
tracking-fennec: ? → 21+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED

          status-firefox21:
          fixed → verified
Keywords: qawanted, 
          
            verifyme
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: