Last Comment Bug 856629 - Implement ChildNode.remove()
: Implement ChildNode.remove()
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla23
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on: 841488 851916 865076 938799
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-01 08:15 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2013-11-14 14:26 PST (History)
7 users (show)
Ms2ger: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part a: Import test for select.remove (8.16 KB, patch)
2013-04-08 11:37 PDT, :Ms2ger (⌚ UTC+1/+2)
mounir: review+
Details | Diff | Splinter Review
Part b: Implement ChildNode.remove() (25.74 KB, patch)
2013-04-08 11:42 PDT, :Ms2ger (⌚ UTC+1/+2)
bzbarsky: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2013-04-01 08:15:06 PDT

    
Comment 1 David Bruant 2013-04-01 09:14:27 PDT
Did you mean Element.remove()? If not, could you link to the spec of ChildNode.remove, please, I'm curious :-)
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2013-04-01 09:55:53 PDT
<http://dom.spec.whatwg.org/#interface-childnode>. That is, Element/CharacterData/DocumentType.
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2013-04-08 11:37:46 PDT
Created attachment 734744 [details] [diff] [review]
Part a: Import test for select.remove

rs?
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2013-04-08 11:42:07 PDT
Created attachment 734746 [details] [diff] [review]
Part b: Implement ChildNode.remove()
Comment 5 Mounir Lamouri (:mounir) 2013-04-09 13:56:04 PDT
Comment on attachment 734744 [details] [diff] [review]
Part a: Import test for select.remove

Review of attachment 734744 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Comment 6 Mounir Lamouri (:mounir) 2013-04-09 14:01:09 PDT
Comment on attachment 734746 [details] [diff] [review]
Part b: Implement ChildNode.remove()

I am at the SysApps F2F this week and I will have a hard time to dedicate time for this review. Hopefully Boris can do that before me. Otherwise, bounce this back to me.
Comment 7 Boris Zbarsky [:bz] (TPAC) 2013-04-09 19:00:22 PDT
Comment on attachment 734746 [details] [diff] [review]
Part b: Implement ChildNode.remove()

The right spec link is http://dom.spec.whatwg.org/#interface-childnode

r=me with that, assuming you'll add the other form of remove() on <select> in bug 841488.
Comment 8 :Ms2ger (⌚ UTC+1/+2) 2013-04-10 02:58:14 PDT
(In reply to Boris Zbarsky (:bz) from comment #7)
> assuming you'll add the other form of remove() on <select> in bug 841488.

I did, didn't I?
Comment 9 Boris Zbarsky [:bz] (TPAC) 2013-04-10 05:39:33 PDT
I didn't look at the patches; just assumed they contain the change.

Note You need to log in before you can comment on or make changes to this bug.