Implement ChildNode.remove()

RESOLVED FIXED in mozilla23

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
4 years ago
3 months ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

({dev-doc-complete})

Trunk
mozilla23
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)

Comment 1

4 years ago
Did you mean Element.remove()? If not, could you link to the spec of ChildNode.remove, please, I'm curious :-)
(Assignee)

Comment 2

4 years ago
<http://dom.spec.whatwg.org/#interface-childnode>. That is, Element/CharacterData/DocumentType.
(Assignee)

Updated

4 years ago
Depends on: 841488, 851916
(Assignee)

Comment 3

4 years ago
Created attachment 734744 [details] [diff] [review]
Part a: Import test for select.remove

rs?
Attachment #734744 - Flags: review?(mounir)
(Assignee)

Comment 4

4 years ago
Created attachment 734746 [details] [diff] [review]
Part b: Implement ChildNode.remove()
Attachment #734746 - Flags: review?(mounir)
Comment on attachment 734744 [details] [diff] [review]
Part a: Import test for select.remove

Review of attachment 734744 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #734744 - Flags: review?(mounir) → review+
Comment on attachment 734746 [details] [diff] [review]
Part b: Implement ChildNode.remove()

I am at the SysApps F2F this week and I will have a hard time to dedicate time for this review. Hopefully Boris can do that before me. Otherwise, bounce this back to me.
Attachment #734746 - Flags: review?(mounir) → review?(bzbarsky)
Comment on attachment 734746 [details] [diff] [review]
Part b: Implement ChildNode.remove()

The right spec link is http://dom.spec.whatwg.org/#interface-childnode

r=me with that, assuming you'll add the other form of remove() on <select> in bug 841488.
Attachment #734746 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 8

4 years ago
(In reply to Boris Zbarsky (:bz) from comment #7)
> assuming you'll add the other form of remove() on <select> in bug 841488.

I did, didn't I?
I didn't look at the patches; just assumed they contain the change.
Keywords: dev-doc-needed
(Assignee)

Comment 10

4 years ago
https://hg.mozilla.org/mozilla-central/rev/942459e50bd0
https://hg.mozilla.org/mozilla-central/rev/9b71c6c95c6c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23

Updated

4 years ago
Depends on: 865076
Docs updated:
https://developer.mozilla.org/en-US/docs/Web/API/ChildNode
https://developer.mozilla.org/en-US/docs/Web/API/ChildNode.remove
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/24
Keywords: dev-doc-needed → dev-doc-complete
Depends on: 938799
Depends on: 1335150

Updated

3 months ago
Depends on: 1345301
You need to log in before you can comment on or make changes to this bug.