Closed
Bug 1335150
Opened 7 years ago
Closed 7 years ago
ChildNode.remove() doesn't work on <option> elements
Categories
(Core :: DOM: Core & HTML, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: florian, Unassigned)
References
Details
Attachments
(2 files)
722 bytes,
patch
|
Details | Diff | Splinter Review | |
1.50 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
In bug 1334831 I used a script to replace .parentNode.removeChild with .remove throughout the tree. I had to exclude the dom/html/test/test_bug394700.html file because that test broke with the change. I'm attaching the portion of the script-generated patch that didn't land due to this test failure. It seems that the implementation of ChildNode.remove() in bug 856629 special cased <select> at http://searchfox.org/mozilla-central/rev/f31f538622d0dfb2d869d4babc4951f6001e9be2/dom/webidl/HTMLSelectElement.webidl#60 I'm wondering if http://searchfox.org/mozilla-central/rev/8fa84ca6444e2e01fb405e078f6d2c8da0e55723/dom/webidl/HTMLOptionsCollection.webidl#20 needs similar treatment.
Comment 1•7 years ago
|
||
No, that's HTMLOptionsCollection, which is not used in the test. HTMLOptionElement doesn't seem to have a remove() that would get in the way. How did the test fail?
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #1) > How did the test fail? See the mochitest failures in https://treeherder.mozilla.org/#/jobs?repo=try&revision=84233092757a51057c0dff3ac5485eab1e6553c1 (note: the bc failures are unrelated, they are bug 1335073).
Comment 3•7 years ago
|
||
Gah, why does that test use ok( == ) rather than is()...
Updated•7 years ago
|
Priority: -- → P2
Comment 4•7 years ago
|
||
This has been fixed with Bug 1345301, so we just need to update the test.
Comment 5•7 years ago
|
||
Updated•7 years ago
|
Attachment #8864021 -
Flags: review?(bugs)
Updated•7 years ago
|
Attachment #8864021 -
Flags: review?(bugs) → review+
Comment 6•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eab37cef2ff30343bd3956570e72d81e16038d40&group_state=expanded
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3db2ccf37a Update test_bug394700 to use .remove instead of .parentNode.removeChild. r=smaug
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1b3db2ccf37a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•