1335150 - ChildNode.remove() doesn't work on <option> elements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Florian Quèze [:florian] (on leave until October 9)]

Attachment: Change to test_bug394700.html

In bug 1334831 I used a script to replace .parentNode.removeChild with .remove throughout the tree. I had to exclude the dom/html/test/test_bug394700.html file because that test broke with the change. I'm attaching the portion of the script-generated patch that didn't land due to this test failure.

It seems that the implementation of ChildNode.remove() in bug 856629 special cased <select> at http://searchfox.org/mozilla-central/rev/f31f538622d0dfb2d869d4babc4951f6001e9be2/dom/webidl/HTMLSelectElement.webidl#60

I'm wondering if http://searchfox.org/mozilla-central/rev/8fa84ca6444e2e01fb405e078f6d2c8da0e55723/dom/webidl/HTMLOptionsCollection.webidl#20 needs similar treatment.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

No, that's HTMLOptionsCollection, which is not used in the test. HTMLOptionElement doesn't seem to have a remove() that would get in the way. How did the test fail?

Comment 2

[Florian Quèze [:florian] (on leave until October 9)]

(In reply to :Ms2ger (⌚ UTC+1/+2) from comment #1)

> How did the test fail?

See the mochitest failures in https://treeherder.mozilla.org/#/jobs?repo=try&revision=84233092757a51057c0dff3ac5485eab1e6553c1
(note: the bc failures are unrelated, they are bug 1335073).

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Gah, why does that test use ok( == ) rather than is()...

Comment 4

[Jessica Jong [:jessica] (inactive)]

This has been fixed with Bug 1345301, so we just need to update the test.

Comment 5

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 6

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eab37cef2ff30343bd3956570e72d81e16038d40&group_state=expanded

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3db2ccf37a
Update test_bug394700 to use .remove instead of .parentNode.removeChild. r=smaug

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1b3db2ccf37a