856772 - support localized strings in manifest prefs

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

We need to support localized strings in manifest prefs to properly display Japanese, Chinese, etc. in about:addons and other UI.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: support non-latin characters in manifests

existing tests pass, and manual testing shows Japanese and Chinese Traditional show up correct now.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 732010 [details] [diff] [review]
support non-latin characters in manifests

I haven't checked that this is exhaustive - please make sure there aren't other readers/setters of the relevant prefs that need to switch to [g|s]etComplexValue.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: support non-latin characters in manifests

updates tests, carry forward r+

Comment 4

[Shane Caraveo (:mixedpuppy)]

https://tbpl.mozilla.org/?tree=Try&rev=0a85c9feb757

Comment 5

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 732121 [details] [diff] [review]
support non-latin characters in manifests

[Approval Request Comment]
User impact if declined: non-latin characers will show garbage in about:addons for social services
Testing completed (on m-c, etc.): try, manually on m-c
Risk to taking this patch (and alternatives if risky): minimal, affects social only
String or IDL/UUID changes made by this patch: none

Comment 6

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d493e9a3a96c

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d493e9a3a96c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bbae3722346f

Comment 9

[u279076]

It appears as though this patch landed with tests. Does this need any QA testing?

Comment 10

[Shane Caraveo (:mixedpuppy)]

No, I think the tests cover the issue.