Closed
Bug 856772
Opened 11 years ago
Closed 11 years ago
support localized strings in manifest prefs
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(firefox22 fixed, firefox23 fixed)
RESOLVED
FIXED
Firefox 23
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
8.64 KB,
patch
|
mixedpuppy
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We need to support localized strings in manifest prefs to properly display Japanese, Chinese, etc. in about:addons and other UI.
Assignee | ||
Comment 1•11 years ago
|
||
existing tests pass, and manual testing shows Japanese and Chinese Traditional show up correct now.
Assignee: nobody → mixedpuppy
Attachment #732010 -
Flags: review?(gavin.sharp)
Comment 2•11 years ago
|
||
Comment on attachment 732010 [details] [diff] [review] support non-latin characters in manifests I haven't checked that this is exhaustive - please make sure there aren't other readers/setters of the relevant prefs that need to switch to [g|s]etComplexValue.
Attachment #732010 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 3•11 years ago
|
||
updates tests, carry forward r+
Attachment #732010 -
Attachment is obsolete: true
Attachment #732121 -
Flags: review+
Assignee | ||
Comment 4•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=0a85c9feb757
Assignee | ||
Updated•11 years ago
|
status-firefox22:
--- → affected
status-firefox23:
--- → affected
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 732121 [details] [diff] [review] support non-latin characters in manifests [Approval Request Comment] User impact if declined: non-latin characers will show garbage in about:addons for social services Testing completed (on m-c, etc.): try, manually on m-c Risk to taking this patch (and alternatives if risky): minimal, affects social only String or IDL/UUID changes made by this patch: none
Attachment #732121 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d493e9a3a96c
Updated•11 years ago
|
Attachment #732121 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d493e9a3a96c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
It appears as though this patch landed with tests. Does this need any QA testing?
Flags: in-testsuite?
Whiteboard: [qa?]
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•