856936 - Update Mozilla Project Review form to use the sec-review? flag instead of the sec-review-needed keyword

Status: RESOLVED FIXED

(bugzilla.mozilla.org Graveyard :: Extensions: MozProjectReview, defect)

Description

[David Lawrence [:dkl]]

By removing the sec-review-needed keyword in bug 855489, the MozProjectReview custom form broke as it has that keyword in the code when creating the sec review dependency bug.

I am temporarily adding the keyword back for a few days til I can push out a proper fix to production later this week.

dkl

Comment 1

[David Lawrence [:dkl]]

Updated the code to add the sec-review? flag to the Security Review child bug and no longer use the sec-review-needed keyword.

To make this work, I also removed mozilla.org :: Security Assurance: Review Request from the exclusions list for the sec-review flag since that is the product/component the child bug needs to be filed under.

I will re-remove the sec-review-needed when this change goes live which will be hopefully in a couple days.

Committing to: bzr+ssh://[e-mail]/bmo/4.2             
modified extensions/MozProjectReview/Extension.pm
Committed revision 8708.

dkl

Comment 2

[David Lawrence [:dkl]]

sec-review-needed keyword has been re-deleted.

dkl

Comment 3

[Daniel Veditz [:dveditz]]

(In reply to David Lawrence [:dkl] from comment #1)
> To make this work, I also removed mozilla.org :: Security Assurance: Review
> Request from the exclusions list for the sec-review flag since that is the
> product/component the child bug needs to be filed under.

The entire point of that exclusion was to make people realize a sec-review? flag was redundant in a component named "Security ... review request"

Comment 4

[David Lawrence [:dkl]]

(In reply to Daniel Veditz [:dveditz] from comment #3) 
> The entire point of that exclusion was to make people realize a sec-review?
> flag was redundant in a component named "Security ... review request"

Sigh. I apologize if I have stepped on the feet of others. The coding design was based on the original requirements of the Mozilla Project Review form. Originally the design was to use the sec-review-need keyword which was removed in favor of the sec-review? flag. I needed to make the change at the time so that the code would work as I was directed and with the component that the Mozilla Project Review form is to use for security review child bugs.

We should discuss the design with mcoates and see if we can make some alterations that will work on all sides. 

dkl

Comment 5

[Daniel Veditz [:dveditz]]

certainly in the short term having some extra flags isn't going to hurt terribly, just logically redundant.

Comment 6

[David Lawrence [:dkl]]

(In reply to Daniel Veditz [:dveditz] from comment #3)
> (In reply to David Lawrence [:dkl] from comment #1)
> > To make this work, I also removed mozilla.org :: Security Assurance: Review
> > Request from the exclusions list for the sec-review flag since that is the
> > product/component the child bug needs to be filed under.
> 
> The entire point of that exclusion was to make people realize a sec-review?
> flag was redundant in a component named "Security ... review request"

Sorry for the delay. But in thinking about this some more. If the project review form will always file its dependent sec-review bug under the component "Security Assurance: Review Request", and you state that it is redundant to have a sec-review? flag set for those bugs. Then all I need do code wise is to just not add the flag when creating the bug. So on my end, I change it to neither add the sec-review-needed keyword or the sec-review? flag and everything will be ok since it is already in the right component. Sound right?

dkl

Comment 7

[Daniel Veditz [:dveditz]]

That sounds right to me.