857034 - Add support for native theming of <input type=range> on Windows

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jonathan Watt [:jwatt]]

We need native theming of <input type=range> on Windows.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 732274 [details] [diff] [review]
patch

>diff --git a/layout/forms/nsRangeFrame.cpp b/layout/forms/nsRangeFrame.cpp
>--- a/layout/forms/nsRangeFrame.cpp
>+++ b/layout/forms/nsRangeFrame.cpp
>@@ -126,17 +126,33 @@ nsRangeFrame::AppendAnonymousContentTo(n
>   aElements.MaybeAppendElement(mThumbDiv);
> }
> 
> void
> nsRangeFrame::BuildDisplayList(nsDisplayListBuilder*   aBuilder,
>                                const nsRect&           aDirtyRect,
>                                const nsDisplayListSet& aLists)
> {
>-  BuildDisplayListForInline(aBuilder, aDirtyRect, aLists);
>+  DisplayBorderBackgroundOutline(aBuilder, aLists);
>+  if (IsThemed()) {

The DisplayBorderBackgroundOutline() call should be inside the |if| block, obviously. I've moved that locally.

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea4b1c3829d3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea4b1c3829d3