Closed Bug 857034 Opened 7 years ago Closed 7 years ago

Add support for native theming of <input type=range> on Windows

Categories

(Core :: Widget: Win32, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

We need native theming of <input type=range> on Windows.
Attached patch patchSplinter Review
Attachment #732274 - Flags: review?(roc)
Comment on attachment 732274 [details] [diff] [review]
patch

>diff --git a/layout/forms/nsRangeFrame.cpp b/layout/forms/nsRangeFrame.cpp
>--- a/layout/forms/nsRangeFrame.cpp
>+++ b/layout/forms/nsRangeFrame.cpp
>@@ -126,17 +126,33 @@ nsRangeFrame::AppendAnonymousContentTo(n
>   aElements.MaybeAppendElement(mThumbDiv);
> }
> 
> void
> nsRangeFrame::BuildDisplayList(nsDisplayListBuilder*   aBuilder,
>                                const nsRect&           aDirtyRect,
>                                const nsDisplayListSet& aLists)
> {
>-  BuildDisplayListForInline(aBuilder, aDirtyRect, aLists);
>+  DisplayBorderBackgroundOutline(aBuilder, aLists);
>+  if (IsThemed()) {

The DisplayBorderBackgroundOutline() call should be inside the |if| block, obviously. I've moved that locally.
Blocks: 841950
https://hg.mozilla.org/mozilla-central/rev/ea4b1c3829d3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Depends on: 859139
Depends on: 1182414
You need to log in before you can comment on or make changes to this bug.