857120 - Display issue when changing the orientation of device in Awesomescreen

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Nightly (2013-04-02)

Firefox 22.0a1 (2013-04-02)
Device: Samsung Galaxy Nexus
OS: Android 4.1.1

Steps to reproduce:
1. Tap on the URL bar to display the Awesomescreen with the URL selected.
2. Tap on Bookmars tab.
3. Swipe left in order to navigate to History tab.
4. While performing step 3, change the orientation of the device from portrait to landscape or viceversa.

Expected result:
- The correct tab is opened without any issues.

Actual result:
- Sometimes the History tab is empty, and sometimes both contents are not aligned correctly.
Note: Please see attached screenshots.

Comment 1

[Aaron Train [:aaronmt]]

Please find a regression range.

Comment 2

[Aaron Train [:aaronmt]]

Awesome-Screen overdraw issue too :( ?

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This adds back the windowBackground from the light theme. As long as we depend on Android's ActionBar -- which has an animation, I don't find another option to solve this.

Comment 4

[Teodora Vermesan (:TeoVermesan)]

Swipe between screens in AwesomeScreen  was implemented on the Nighty build from 13th of November. And I see the issue since then. So, the regression range is between 12.11.2012 and 13.11.2012. 
The pushlog is: 
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b2bdbfe06b10&tochange=1b0226622e94

Comment 5

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9dc4053ff155

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9dc4053ff155

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - Uplift needed?

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 732456 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 844984.
User impact if declined: There will be visual glitches due to animations in AwesomeBar.
Testing completed (on m-c, etc.): Landed in m-c on 04/03
Risk to taking this patch (and alternatives if risky): None. This restores back the windowBackground that we used to have.
String or IDL/UUID changes made by this patch: None.

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 732456 [details] [diff] [review]
Patch

Are the affected flags on this bug correct? a+ for Aurora regardless.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/88f3ce70814d

Comment 11

[u421692]

The issue is still reproducing on latest Nightly 23.0a1 (2013-04-19) on both tablet and phone. Reopening bug.

I've used the steps presented in bug in order to reproduce this issue:
1. Tap on the URL bar to display the Awesomescreen with the URL selected.
2. Tap on Bookmars tab.
3. Swipe left in order to navigate to History tab.
4. While performing step 3, change the orientation of the device from portrait to landscape or viceversa.
NOTE!: You should try a few times to reproduce this issue since there is only a small time interval between swiping and changing orientation when this issue is reproducing.

Comment 12

[Aaron Train [:aaronmt]]

Please find a regression-range.

Comment 13

[u421692]

The patch seems to not have fixed this issue, since this is reproducible on Nightly 23.0a1 (2013-04-03) and Nightly 23.0a1 (2013-04-04) in which the patch has landed. Therefore, the regression range remains the same as presented in Comment 4
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b2bdbfe06b10&tochange=1b0226622e94.

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

Given the STR, this bug should not be tracking.

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Agreed that we shouldn't track here because STR in comment 11 makes this sound not very easily reproducible but do we want to keep this patch landed (in Aurora at least) when it doesn't seem to have done anything effective?

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Sriram can you address comment 15? Should we back out the landing in comment 10 from aurora given that it seems not to work?

Comment 17

[Aaron Train [:aaronmt]]

Sriram's out for a few weeks; maybe Lucas?

Comment 18

[Lucas Rocha (:lucasr)]

(In reply to [e-mail] from comment #16)
> Sriram can you address comment 15? Should we back out the landing in comment
> 10 from aurora given that it seems not to work?

My concern here is the possibility of causing another regression by backing it out because of changes made after this patch landed.

Maybe a safer option is back it out in Nightly first? If it doesn't cause any problems, we can then back it out in Aurora. Agree?

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Sriram - can you do the backout on Nightly and confirm whether a backout on Aurora will be safe as well?

Comment 20

[Lukas Blakk [:lsblakk] use ?needinfo]

Sorry - I meant to ask Lucas since Sriram is out.

Comment 21

[Alex Keybl [:akeybl]]

We'll untrack since the risk of regression from a back out is greater than the user impact of this bug.

Comment 22

[Brian Nicholson (:bnicholson)]

Mihai -- I'm guessing this is fixed now with the new home redesign, so can you verify that's the case and mark this resolved if so? Thanks.

Comment 23

[u421692]

Attachment: screenshot

Comment 24

[u421692]

The issue is reproducing in a similar way, but I was able to reproduce it so far only by changing from Reading list tab to History tab and viceversa. Please see attached screenshot.

Comment 25

[Aaron Train [:aaronmt]]

What were your exact steps to reproduce and device used?

Comment 26

[u421692]

Device: Samsung Galaxy Tab (Android 4.0.4)

Steps to reproduce:
1. Open Firefox and open about:home.
2. Tap on Reading list.
3. Swipe left in order to navigate to History tab.
4. While performing step 3, change the orientation of the device from portrait to landscape or viceversa.

Comment 27

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.