857862 - Defect - Selection monocles don't show up on sites using content editable (like outlook.com)

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect, P2)

Description

[Jim Mathies [:jimm]]

str:

1) compose a new message on outlook.com
2) type in some text into the message view
3) tap within the text you type

result: no caret monocle

if you select some text you don't get start or end monocles either.

Comment 1

[Jim Mathies [:jimm]]

This is really a more general problem of not supporting content editable in the current selection handler code.

Comment 2

[Marco Mucci [:MarcoM]]

Jim's point estimate=5

Comment 3

[Allison Naaktgeboren :ally]

Is there anything blocking or holding this up?

Comment 4

[Jim Mathies [:jimm]]

(In reply to :Ally Naaktgeboren from comment #3)
> Is there anything blocking or holding this up?

No, and it's a definite selection blocker.

Comment 5

[Jim Mathies [:jimm]]

Attachment: contenteditable testcase

Comment 6

[Jim Mathies [:jimm]]

Attachment: content editable support v.1

Comment 7

[Jim Mathies [:jimm]]

Attachment: content editable support v.1

Comment 8

[Jim Mathies [:jimm]]

Attachment: tests

Comment 9

[Jim Mathies [:jimm]]

Comment on attachment 770731 [details] [diff] [review]
tests

This needs a setDevPixelEqualToPx() call. The coordinates are off on test slaves.

Comment 10

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 770730 [details] [diff] [review]
content editable support v.1

Review of attachment 770730 [details] [diff] [review]:
-----------------------------------------------------------------

Clean local test run, looks good to me.

::: browser/metro/base/content/Util.js
@@ +185,5 @@
>              aElement instanceof Ci.nsIDOMHTMLTextAreaElement);
>    },
>  
> +  isEditableContent: function isEditableContent(aElement) {
> +    if (!aElement)

Is it worth also checking you get an element? E.g. aElement.nodeType==1

Comment 11

[Jim Mathies [:jimm]]

Attachment: tests

Comment 12

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #11)
> Created attachment 771654 [details] [diff] [review]
> tests

try run:
https://tbpl.mozilla.org/?tree=Try&showall=0&rev=638f75179575

Comment 13

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 771654 [details] [diff] [review]
tests

Review of attachment 771654 [details] [diff] [review]:
-----------------------------------------------------------------

The try run came up green. r+ with comments.

::: browser/metro/base/tests/mochitest/browser_selection_contenteditable.js
@@ +37,5 @@
> +  run: function test() {
> +    let div = gWindow.document.getElementById("testdiv");
> +    ok(div, "have the div");
> +
> +    sendElementTap(gWindow, div, 295); // end of 'outlook.com'

What does this 295 magic number come from?

::: browser/metro/base/tests/mochitest/head.js
@@ +639,5 @@
>  
>  TouchDragAndHold.prototype = {
>    _timeoutStep: 2,
>    _numSteps: 50,
> +  _debug: true,

Did you mean to commit this change to the _debug flag?

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d412604544ac
https://hg.mozilla.org/mozilla-central/rev/fd19f8ea452e

Comment 15

[Samvedana (:Samvedana)]

User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:25.0) Gecko/20130717 Firefox/25.0
Build ID: 20130717030207

Works for me.
Tested for iteration 10 on latest nightly from ftp://ftp.mozilla.org/pub/firefox/nightly/2013/07/2013-07-17-03-02-07-mozilla-central/ 
using windows 8.1 preview.

I see selection monocles for editable content.

Comment 16

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130806104538
Built from http://hg.mozilla.org/mozilla-central/rev/1e381c91885d

WFM
Tested on windows 8 using latest nightly for iteration-11. Followed steps provided in comment0 and I got caret monocle after tapping. When I selected some text I got start and end monocles.

Comment 17

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130816030205
Built from http://hg.mozilla.org/mozilla-central/rev/1ed5a88cd4d0

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and I got caret monocle after tapping. When I selected some text I got start and end monocles.