Rename social.activated.undobutton.label entity and fix "..."

RESOLVED FIXED in Firefox 23

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: flod, Assigned: mixedpuppy)

Tracking

Trunk
Firefox 23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
There were some problems in the patch landed in bug 836452

-<!ENTITY social.activated.undobutton.label "Undo">
+<!ENTITY social.activated.undobutton.label "Oops, undo this!">

You can't do this, you need a new entity name if you want to change the original string.

<!ENTITY social.learnMore.label "Learn more...">
service.install.learnmore=Learn More...

AFAIK Mozilla consistently uses a single unicode character "…" instead of "...". This can be fixed without changing entity name, considering it's a matter of consistency inside en-US.
 # LOCALIZATION NOTE (social.activated.description): %1$S is the name of the social provider, %2$S is brandShortName (e.g. Firefox)
-social.activated.description=You've turned on %1$S for %2$S.
+service.install.description=Would you like to enable services from %1$S to display in your %2$S toolbar and sidebar?

The LOCALIZATION NOTE needs to be updated as well.


The following should rather use common placeholders. It should not include xml tags.

+<!ENTITY social.activated.description "Services from <label/> have been enabled. You can change your settings for services in the <label class='text-link'>Add-on Manager</label>.">
(Assignee)

Comment 2

5 years ago
(In reply to Vlado Valastiak [:wladow] @ Mozilla.sk from comment #1)
> The following should rather use common placeholders. It should not include
> xml tags.
> 
> +<!ENTITY social.activated.description "Services from <label/> have been
> enabled. You can change your settings for services in the <label
> class='text-link'>Add-on Manager</label>.">

This is used elsewhere in dtd files (see abouthome.defaultSnippet1.v1, aboutSupport.pageSubtitle), but I'm fine changing it.  What do you suggest as common placeholders that could insert into dom as elements?
(Assignee)

Comment 3

5 years ago
Created attachment 733634 [details] [diff] [review]
fixes for l10n

this fixes everything except the social.activated.description entity, will wait on response for that.
Assignee: nobody → mixedpuppy
Vlado, can you comment on comment 2?
Flags: needinfo?(wladow)
Blocks: 836452
No longer depends on: 836452
(Assignee)

Comment 5

5 years ago
Comment on attachment 733634 [details] [diff] [review]
fixes for l10n

short try:
https://tbpl.mozilla.org/?tree=Try&rev=e0b029ba85d3

The issue from comment #2 can be dealt with in a followup if there is a better way.
Attachment #733634 - Flags: review?(gavin.sharp)
Attachment #733634 - Flags: review?(gavin.sharp) → review+

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/52a3f6123009
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Whiteboard: [qa-]
Flags: needinfo?(wladow)
You need to log in before you can comment on or make changes to this bug.