857930 - Installing a packaged app that causes an error at download time leaves a broken app icon/text on the about:apps page

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Jason Smith [:jsmith]]

Device: Galaxy Nexus
OS: Android 4.2

STR

1. Install a packaged app that will cause an error at either install/download time. Examples:
* Install any packaged app from marketplace right now
* Install "Packaged App Test Case 1" from http://mozqa.com/webapi-permissions-tests/

Expected

We haven't implemented the download UI yet, so excluding that piece (since it's not implemented yet), I'd expect we would fail to install, but the failure should be clean - nothing left behind in the UI.

Actual

We fail to install, but a broken app icon/text gets left behind on the about:apps page. It's completely unfunctional as well if you try to click it. You can hard press to uninstall it, however.

Probably the simple fix here is that we should only add the app icon/text if the install is successful and not add it if we fail.

Comment 1

[Jason Smith [:jsmith]]

Errors during download of a packaged app actually is common use-case wise for a mobile device - you can get errors for many reasons such as:

* Loss of network connection (e.g. data/wifi loss)
* Bad signature (e.g. install any reviewer app without the right cert)
* Other odd random internal errors (e.g. archive corruption due to packet loss during download)

We shouldn't leave behind obvious broken UI on the basic error cases.

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Attachment: Delete failed web app from about:apps

Comment 3

[Jason Smith [:jsmith]]

Comment on attachment 738277 [details] [diff] [review]
Delete failed web app from about:apps

I think you meant to flag fabrice's mozilla.com address.

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 738277 [details] [diff] [review]
Delete failed web app from about:apps

Review of attachment 738277 [details] [diff] [review]:
-----------------------------------------------------------------

That's not the way to fix this bug. Here you are changing the backend behavior while the issue is in Fennec's frontent. For instance Gaia has the UI to restart failed downloads - I guess this is what you should do there, and use the installState if you want to hide apps that are in pending install state.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

This can ride the trains

Comment 7

[James Hugman [:jhugman] [@jhugman]]

Is this bug still relevant in the light of MOZ_ANDROID_SYNTHAPKS?

Comment 8

[Aaron Train [:aaronmt]]

There's still an issue here. It seems like the app package is not registered properly in about:apps (this may be another in-progress open bug). Also noticed no application icon used in the APK.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

(In reply to Aaron Train [:aaronmt] from comment #8)
> There's still an issue here. It seems like the app package is not registered
> properly in about:apps (this may be another in-progress open bug). Also
> noticed no application icon used in the APK.

I'm pretty sure this is a different issue, and I suspect it's also been resolved already.

Aaron: can you still reproduce it?

Comment 10

[Aaron Train [:aaronmt]]

All problems mentioned are now resolved on recent trunk builds.