858148 - line spacing around lists changed by recent update

Status: RESOLVED FIXED

(Websites :: wiki.mozilla.org, defect)

Description

[John Karahalis [:openjck]]

A recent update (maybe within the last 1-2 weeks) seems to have changed the spacing between lists and other elements. This is far from a major problem, but it does make some existing pages difficult to read.

For more information, and some examples, please see the following page.

https://wiki.mozilla.org/User:John_Karahalis/FormattingDemo

Comment 1

[Mark A. Hershberger (hexmode)]

Investigating

Comment 2

[Wayne Mery (:wsmwk)]

from IRC 
hexmode> wsm: fix is adding "ul {margin-bottom: 1em;}" to css

Comment 3

[Wayne Mery (:wsmwk)]

other testcase https://wiki.mozilla.org/Grow/Meeting_04_04_13
from bug 857891

Comment 5

[Wayne Mery (:wsmwk)]

Attachment: list spacing

My affected page is https://wiki.mozilla.org/Thunderbird:Testing:Memory_Usage_Problems - which looks horrible in comparison to David Boswell's example

Comment 7

[Gervase Markham [:gerv]]

Can we simply add the fix to the main CSS file?

I've added it for my pages; please remove that if you add it globally.

Don't forget to fix it for both "ul" and "ol".

Gerv

Comment 8

[Mark A. Hershberger (hexmode)]

This change can be made on-wiki.  The page MediaWiki:Common.css needs to be updated.

The rule I gave before is being overridden by some RTL interface fixes and needs to be modified.  I've added the following to https://wiki.mozilla.org/MediaWiki:Common.css:


 /* Correct directionality when page dir is different from site/user dir */
 .mw-content-ltr ul,
 .mw-content-rtl .mw-content-ltr ul {
	/* @noflip */
	margin: 0.3em 0 1em 1.6em;
 }

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to Mark A. Hershberger (hexmode) from comment #8)
> I've added the following to https://wiki.mozilla.org/MediaWiki:Common.css:

that helped https://wiki.mozilla.org/Thunderbird:Testing:Memory_Usage_Problems

Comment 10

[Mark A. Hershberger (hexmode)]

This should be fixed now.  Please verify and close or update with issues.

Comment 11

[John Karahalis [:openjck]]

Also fixed the page I linked in comment 0.

Comment 12

[Gervase Markham [:gerv]]

hexmode: the fix you've put in seems to be just for "ul" - do you need to fix "ol" also?

Gerv

Comment 13

[Mark A. Hershberger (hexmode)]

(In reply to Gervase Markham [:gerv] from comment #12)
> hexmode: the fix you've put in seems to be just for "ul" - do you need to
> fix "ol" also?

Right.  Fixed now.

Comment 14

[Gervase Markham [:gerv]]

LGTM.

Gerv

Comment 15

[SeaBuggy]

Does this problem include the vertical spacing between e-mail subject lines when listing the contents of e-mail folders?  With the latest update, 2.22.1, there is suddenly way too much vertical space between list items and between the folder names in the left frame.  I have to say I intensely dislike it.  It's a complete waste of space.

Comment 16

[Gervase Markham [:gerv]]

(In reply to SeaBuggy from comment #15)
> Does this problem include the vertical spacing between e-mail subject lines
> when listing the contents of e-mail folders? 

No - this is a bug in a website, not a bug in Thunderbird. And it's been resolved for 4 months.

Gerv