858155 - Auto-complete menus can span the entire screen

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect)

Description

[Jim Mathies [:jimm]]

Attachment: really wide auto-complete screen shot

related: bug 857986

See screenshot.

Comment 1

[Jim Mathies [:jimm]]

Both width and height are an issue.

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch

Comment 3

[Jim Mathies [:jimm]]

Attachment: patch

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 733514 [details] [diff] [review]
patch

what this does:

- restricts auto-completes to the width of the parent input
- restricts the height of auto-completes to a max of 350px.
- puts the left or right hand padding back on forcePosition menus, which got clipped out at some point.

Comment 5

[Frank Yan (:fryn)]

Comment on attachment 733514 [details] [diff] [review]
patch

Review of attachment 733514 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: browser/metro/base/content/helperui/MenuUI.js
@@ +48,2 @@
>      options.source = Ci.nsIDOMMouseEvent.MOZ_SOURCE_TOUCH;
>      return options;

Nit: Could you make this function body look like the following before landing?
function _positionOptions() {
  return {
    forcePosition: true;
    ...
    source: Ci.nsIDOMMouseEvent.MOZ_SOURCE_TOUCH;
  };
}

@@ +417,5 @@
> +    let leftHand = MetroUtils.handPreference == MetroUtils.handPreferenceLeft;
> +    if (aSource && aSource == Ci.nsIDOMMouseEvent.MOZ_SOURCE_TOUCH) {
> +      if (leftHand) {
> +        this._commands.setAttribute("left-hand", true);
> +        this._commands.removeAttribute("right-hand");

If this is a binary setting, could we change this to just use one attribute? (If that's the case, let's file a followup and deal with it later.)

Comment 6

[Frank Yan (:fryn)]

Oops, I meant the following, not the semi-colons:

function _positionOptions() {
  return {
    forcePosition: true,
    ...
    source: Ci.nsIDOMMouseEvent.MOZ_SOURCE_TOUCH
  };
}

Comment 7

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a99f51a4d7c

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0a99f51a4d7c