858181 - Regression: Position fixed footer on Duck Duck Go floats above other content

Status: RESOLVED DUPLICATE of bug 856497

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=44cf42a8e6e5&tochange=15e82d1c776a

This looks to be a regression from http://hg.mozilla.org/integration/mozilla-inbound/rev/d91a87b222e4 via bug 853831

See attached screenshot (steps, simply visit http://www.duckduckgo.com)

--
Nightly/Aurora (04/04)
LG Nexus 4 (Android 4.2.2)

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Nightly (04/04) - Screenshot

Screenshot at the time of filing on Nightly (04/04)

Comment 2

[Aaron Train [:aaronmt]]

For the other layout issue regarding the search button, see bug 841363

Comment 3

[Chris Lord [:cwiiis]]

To clarify, the bug here isn't that the bar is above the text box (which would happen, looking at the page structure), but that it's higher than it should be (which shouldn't happen - the position:fixed bar is aligned to the bottom). There's a chance this could be to bug 856932, but I have a hard time duplicating it on the razri.

There seems to be other badness going on on this page where the bottom bar turns invisible... I'm not sure if this is JS doing this, gfx bugs, layout bugs... Possibly JS scrolling isn't affecting fixed margins correctly?

Some break down of the issues on this page, with consistent STR would be good.

Comment 4

[Chris Lord [:cwiiis]]

Argh, so it seems that the fixed margins don't always change correctly when the page changes size, which is likely causing some of the badness on this site (and is causing badness on another bug I'm trying to fix...) - I'll fix that as part of this bug.

Comment 5

[Chris Lord [:cwiiis]]

Just tested, this same bug exists on FirefoxOS, but I think they use this same code now? (it used to be duplicated elsewhere in the tree, but I can't remember off-hand where that was)

Adding needinfo?benfrancis (if you don't know, please pass it on to someone that might :))

This is a really low-risk, high-impact fix, let's uplift it wherever we can.

Comment 6

[Chris Lord [:cwiiis]]

Argh, wrong bloody tab...

Comment 7

[Chris Lord [:cwiiis]]

The possibility of the bar not being attached to the bottom will be fixed by the patch I just attached to bug 856497. That it's above content in terms of z-ordering is down to the page, so I'm duping this (but please reopen if you think I'm wrong).