Closed Bug 858383 Opened 8 years ago Closed 8 years ago

[Keyboard] Integrate the new keyboard manager with switch and show layout list functions in Keyboard app.

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

x86
macOS
defect

Tracking

(blocking-b2g:koi+)

RESOLVED FIXED
blocking-b2g koi+

People

(Reporter: evanxd, Assigned: rudyl)

References

Details

(Whiteboard: [FT:System-Platform, koi:p1, Sprint: 2])

Attachments

(1 file, 2 obsolete files)

Please refer to bug 816912.
And the mate bug of this bug is bug 816869.

Integrate the new keyboard manager supported 3rd-party keyboard apps 
with switch and show layout list functions in Keyboard app.
Assignee: nobody → evanxd
Thanks :)
Attachment #733723 - Flags: review?(rlu)
Attachment #733723 - Flags: review?(ehung)
To test this patch, please also apply patch in the bug 816912(In reply to Evan Tseng from comment #1)
> Created attachment 733723 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9001
> 
> Thanks :)

To test this patch, I guess we also need patch in the bug 816912
Depends on: 816912
Hi Evelyn,

Yes, you are right.
Thanks.

To test these two patch, we might also need the new Keyboard APIs supporting.
For Keyboard App, it used the window.navigator.mozKeyboard.inputType API.
And I already wrote the email to Xulei.
Hi Xulei, any schedule of landing mozKeyboard API in Gecko side? We hope we could land both keyboard manager (in bug 816912) and keyboard app patches (here) by the end of this week. We don't want to break anything on gaia master so we should make sure there is no impact if mozKeyboard API can't be landed in time.
Flags: needinfo?(xyuan)
Comment on attachment 733723 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9001

commented on Github. 
I'll leave the r? decision to Rudy because he knows more keyboard app.
Attachment #733723 - Flags: review?(ehung)
(In reply to Evelyn Hung [:evelyn] from comment #5)
> Comment on attachment 733723 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9001
> 
> commented on Github. 
> I'll leave the r? decision to Rudy because he knows more keyboard app.

Rudy, please test carefully to make sure we didn't break anything. The keyboard app should work as before.
Hi Evelyn,

I got it.
And I also updated the code for your comments.

Thanks. :)
(In reply to Evelyn Hung [:evelyn] from comment #4)
> Hi Xulei, any schedule of landing mozKeyboard API in Gecko side? We hope we
> could land both keyboard manager (in bug 816912) and keyboard app patches
> (here) by the end of this week. We don't want to break anything on gaia
> master so we should make sure there is no impact if mozKeyboard API can't be
> landed in time.

The patch of extended mozKeyboard API will be ready this week, but I can't not ensure that it can land by this weekend, since it may require more than one week to review.

To remove the dependency of extended mozKeyboard API, you only need to remove the reference of  mozKeyboard.inputType in gaia side.
Flags: needinfo?(xyuan)
Hi all,

Thanks for the work.
I found several issues when I test this patch with that of bug 816912.

1. The latency to show the keyboard is noticeable.
   Most of the time, the keyboard will be shown with some keys that are not rendered completely.
   Sometimes, it will show the background (of homescreen) first and then the keyboard appears.

2. Long press the "switch language" and select one of the layouts.
   There are several issues here, sometimes we cannot switch the language again.
   Let's talk about this face-to-face.

3. Right now all keyboard layouts are enabled by default.
   Is this by intention?

4. :djf made some modification in 132c5a712ec4d4e92208ba4fc65ca98b8be00b31 for keyboard auto-correction, we might need to update the code to accommodate that change, or it seems word suggestion could not work.
Hi all,

I found a new issues.

After switched to a new keyboard layout from default one, user clicked another input filed. And the keyboard manager showed the default layout, not the new one.
Hi all,

This bug are waiting for UI spec and new Keyboard APIs.
Comment on attachment 733723 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9001

clear the review flag for now.
Attachment #733723 - Flags: review?(rlu)
Blocks: 891673
Will take this and give an update patch.
Assignee: evanxd → rlu
Hi Rudy,

Thanks for your help. :)
WIP here,
https://github.com/RudyLu/gaia/tree/3rdParty_keyboard

The latest change to integrate the new Keyboard app with Gary's work on keyboard_manager is this commit,
https://github.com/RudyLu/gaia/commit/ce92c95cf4139f7da78caa7db3cd82a244dd3ede
blocking-b2g: --- → koi+
Depends on: 899505
Add white board key words for tracking
Whiteboard: [ucid:SystemPlatform1], [FT: System Platform], [Sprint: 2]
Priority: -- → P1
Comment on attachment 790117 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11527

Hi David, Tim,

Please help review the 1st part of the big changes we need for 3rd-party keyboard support.

I would need your help to review this commit only, which is focused on keyboard app itself.
https://github.com/mozilla-b2g/gaia/commit/92235a8ce3ea4a4902bb11871ba485158b8e486b 

The other 2 commits are needed to test the new IME framework and will be reviewed by other module peers/owners but feel free to take a look if you are interested.

Some cleanup and work are not done yet, listed below, but I would like to send this patch first and get your feedback.
  
[Work to be done]
  1. Move settings from mozSettings to keyboard app itself.
     - and cleanup all references to keyboard layout settings.
  2. Modify latin IME to use onsurroundingtextchange and composition related API.
  
Thank you.
Attachment #790117 - Flags: review?(timdream)
Attachment #790117 - Flags: review?(dflanagan)
Comment on attachment 790117 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11527

Looks good, some nits need to be addressed though.
Attachment #790117 - Flags: review?(dflanagan) → review+
Comment on attachment 790117 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11527

I think I switch the wrong flag :-/ Sorry about that.
Attachment #790117 - Flags: review?(timdream) → review?(dflanagan)
Blocks: 906096
Attached file pull_3rdPartyIME.html
Send another pull request (commits squashed) to make the original one keep the review comments.
carry over the r+.
Attachment #733723 - Attachment is obsolete: true
Attachment #790117 - Attachment is obsolete: true
Attachment #790117 - Flags: review?(dflanagan)
Attachment #795057 - Flags: review+
Landed to Gaia master (finally!!)
bc8c1c962addd419b48ba12c6d8ddabdf9805391
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
backed out as part of the general backout of the 3rd party keyboard customizations (https://github.com/mozilla-b2g/gaia/commit/42aa1e2ccd22e464bffe6b22ee1182cece5dc2dc) Due to b2g-desktop failures (fail to start) https://travis-ci.org/mozilla-b2g/gaia/builds/10571231#L129.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [ucid:SystemPlatform1], [FT: System Platform], [Sprint: 2] → [ucid:SystemPlatform1, FT: System-Platform, koi:p1, Sprint: 2]
Whiteboard: [ucid:SystemPlatform1, FT: System-Platform, koi:p1, Sprint: 2] → [ucid:SystemPlatform1, FT:System-Platform, koi:p1, Sprint: 2]
Remove ucid from the white board since this is engineering bug
Whiteboard: [ucid:SystemPlatform1, FT:System-Platform, koi:p1, Sprint: 2] → [FT:System-Platform, koi:p1, Sprint: 2]
Merged to Gaia master with this rev,
https://github.com/mozilla-b2g/gaia/commit/9fb5802df60a9081846d704def01df814ed8fbd4
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Depends on: 918863
You need to log in before you can comment on or make changes to this bug.