858393 - "OSError: [Errno 17] File exists: <random file>"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Philip Chee]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1365132147.1365132998.11766.gz#err0
OSError: [Errno 17] File exists: '/builds/slave/c-cen-t-osx64-dbg/build/objdir/mozilla/dom/imptests/failures/html/html/browsers/the-window-object'
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1365132119.1365132913.11696.gz
OSError: [Errno 17] File exists: '/builds/slave/c-cen-t-osx64/build/objdir/i386/mozilla/dom/imptests/failures/html/html/dom/documents/dom-tree-accessors/document.getElementsByName'
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1365125616.1365126528.32173.gz
OSError: [Errno 17] File exists: '/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dom/imptests/failures/html/html/semantics/tabular-data/the-table-element'

Looks like a regression from:
Bug 747393 - JarMaker.py races - "OSError: [Errno 17] File exists: '../../dist/bin/chrome/browser/content/browser'"

Possibly caused by Bug 812179 - Removed hacks for Python < 2.6 from config/

Comment 1

[Mike Hommey [:glandium]]

It's unrelated, but is the same underlying problem, just showing up at a different place. It comes from bug 784841.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Avoid race condition creating directories in config.status

There are too many places using os.makedirs without doing this, we really need to do something about it, but i don't feel like doing it right away. We need to figure out where to put such general purpose function. I'll file a follow-up bug.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 733744 [details] [diff] [review]
Avoid race condition creating directories in config.status

Review of attachment 733744 [details] [diff] [review]:
-----------------------------------------------------------------

*sigh*

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/970623e75393

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/970623e75393