Closed
Bug 858594
Opened 11 years ago
Closed 11 years ago
Work - Some select popups don't position correctly under the parent form input
Categories
(Firefox for Metro Graveyard :: Input, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: jimm, Assigned: sfoster)
References
Details
(Whiteboard: [forms] feature=work)
Attachments
(2 files, 1 obsolete file)
|
13.13 KB,
image/png
|
Details | |
|
3.90 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
screenshot
See screen shot. There are misalignment problems and the widths don't always match input widths.
|
||
Updated•11 years ago
|
Blocks: metrov1defect&change
|
|
||
Updated•11 years ago
|
Summary: Some select popups don't position correctly under the parent form input → Defect - Some select popups don't position correctly under the parent form input
Whiteboard: [forms] → [forms] feature=defect c=tbd u=tbd p=0
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [forms] feature=defect c=tbd u=tbd p=0 → [forms] feature=defect c=tbd u=tbd p=2
|
|
||
Comment 1•11 years ago
|
||
Jim's point estimate=2
Whiteboard: [forms] feature=defect c=tbd u=tbd p=2 → [forms] feature=defect c=tbd u=tbd p=0
|
||
Updated•11 years ago
|
Priority: -- → P3
|
|
||
Updated•11 years ago
|
No longer blocks: metrov1defect&change
Summary: Defect - Some select popups don't position correctly under the parent form input → Work - Some select popups don't position correctly under the parent form input
Whiteboard: [forms] feature=defect c=tbd u=tbd p=0 → [forms] feature=work
|
Assignee | |
Comment 2•11 years ago
|
||
I concur, sometimes popups seem to align to the left edge of the label+field? Or is it the table row that contains both TH and TD. Controls are usable, would be nice to tighten up though.
|
|
Assignee | |
Comment 3•11 years ago
|
||
The rect for positioning options popups ultimately comes from FormHelper._getRect, which was calling _getLabels to include any nearby label. That's not the behavior we want here. It probably is the behavior we want if we need to scroll/pan to a given form element though so I've put that inside an option check.
Assignee: nobody → sfoster
Attachment #829395 -
Flags: review?(mbrubeck)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Just cleaning up the patch a bit
Attachment #829395 -
Attachment is obsolete: true
Attachment #829395 -
Flags: review?(mbrubeck)
Attachment #829402 -
Flags: review?(mbrubeck)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 829402 [details] [diff] [review] Don't include associated label's bounding box by default when getting positioning rect for options popup Review of attachment 829402 [details] [diff] [review]: ----------------------------------------------------------------- I'd also be happy to remove the label-fetching code entirely... though I guess it would be useful if we ever implement zoom-to-focused-element again.
Attachment #829402 -
Flags: review?(mbrubeck) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
On fx-team: https://hg.mozilla.org/integration/fx-team/rev/b9c3eedbf239
|
|
||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b9c3eedbf239
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
|
||
Comment 8•11 years ago
|
||
Verified on x86_64 on Win8 Metro, found not fixed.
|
||
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•