Closed Bug 858759 Opened 7 years ago Closed 7 years ago

profiler.css in browser/devtools/ should actually be in browser/themes instead

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: vporof, Assigned: anton)

References

Details

Attachments

(1 file, 1 obsolete file)

Shouldn't it?
Blocks: 858765
Tested on OS X. Going to test it on Linux in a bit and then find someone with Windows to test it for me.
Assignee: nobody → anton
Status: NEW → ASSIGNED
Attachment #735545 - Flags: review?(vporof)
Nvm, my Linux box seems busted.
Comment on attachment 735545 [details] [diff] [review]
Move profiler.css to browser/themes

Review of attachment 735545 [details] [diff] [review]:
-----------------------------------------------------------------

This should theoretically work on other platforms too, but it wouldn't hurt to test.

::: browser/themes/linux/devtools/profiler.css
@@ +1,5 @@
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +%include ../../shared/devtools/profiler.inc.css
\ No newline at end of file

Isn't this a bit premature for just 3 selectors? :) But anyway, I like it.

::: browser/themes/windows/jar.mn
@@ +437,4 @@
>          skin/classic/aero/browser/devtools/splitview.css             (devtools/splitview.css)
>          skin/classic/aero/browser/devtools/styleeditor.css           (devtools/styleeditor.css)
>          skin/classic/aero/browser/devtools/debugger.css              (devtools/debugger.css)
> +*       skin/classic/aero/browser/devtools/profiler.css              (devtools/profiler.css)

You forgot to put profiler.css in the classic skin as well.
Attachment #735545 - Flags: review?(vporof) → review+
(R+ with the change in windows/jar.mn)
Added profiler.css to the classic Windows theme. Carrying over r+.
Attachment #735545 - Attachment is obsolete: true
Attachment #735867 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/d1264794ca7e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.