858759 - profiler.css in browser/devtools/ should actually be in browser/themes instead

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Victor Porof [:vporof][:vp]]

Shouldn't it?

Comment 1

[Anton Kovalyov (:anton)]

Attachment: Move profiler.css to browser/themes

Tested on OS X. Going to test it on Linux in a bit and then find someone with Windows to test it for me.

Comment 2

[Anton Kovalyov (:anton)]

Nvm, my Linux box seems busted.

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 735545 [details] [diff] [review]
Move profiler.css to browser/themes

Review of attachment 735545 [details] [diff] [review]:
-----------------------------------------------------------------

This should theoretically work on other platforms too, but it wouldn't hurt to test.

::: browser/themes/linux/devtools/profiler.css
@@ +1,5 @@
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +%include ../../shared/devtools/profiler.inc.css
\ No newline at end of file

Isn't this a bit premature for just 3 selectors? :) But anyway, I like it.

::: browser/themes/windows/jar.mn
@@ +437,4 @@
>          skin/classic/aero/browser/devtools/splitview.css             (devtools/splitview.css)
>          skin/classic/aero/browser/devtools/styleeditor.css           (devtools/styleeditor.css)
>          skin/classic/aero/browser/devtools/debugger.css              (devtools/debugger.css)
> +*       skin/classic/aero/browser/devtools/profiler.css              (devtools/profiler.css)

You forgot to put profiler.css in the classic skin as well.

Comment 4

[Victor Porof [:vporof][:vp]]

(R+ with the change in windows/jar.mn)

Comment 5

[Anton Kovalyov (:anton)]

Attachment: Move profiler.css to browser/themes

Added profiler.css to the classic Windows theme. Carrying over r+.

Comment 6

[Anton Kovalyov (:anton)]

https://hg.mozilla.org/integration/fx-team/rev/d1264794ca7e

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/d1264794ca7e