Closed
Bug 858833
Opened 11 years ago
Closed 11 years ago
during an update, downloadAvailable is sometimes not reset to false after an error, when it should
Categories
(Core Graveyard :: DOM: Apps, defect)
Tracking
(firefox21 wontfix, firefox22 wontfix, firefox23 fixed, b2g18+ fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix)
RESOLVED
FIXED
mozilla23
People
(Reporter: julienw, Assigned: julienw)
References
Details
Attachments
(1 file)
1.30 KB,
patch
|
fabrice
:
review+
lsblakk
:
approval-mozilla-b2g18+
|
Details | Diff | Splinter Review |
STR: * install a packaged app that you control * change the update manifest, and corrupt the zip * check for updates * accept the update Expected: * the update is downloaded and then the notification disappear because the error is not recoverable by the user. After some time a banner shows up explaining there was an error. Actual: * the expected behaviour happens, except the notification does not disappear. This STR should be used with the patch for Bug 837193 which implements the removal of the notification.
Assignee | ||
Comment 1•11 years ago
|
||
When updating an app, the installState is not "installed" but "updating. So I changed the test to test that it's not "pending" instead, as in other places. The STR works fine with this change.
Attachment #734125 -
Flags: review?(fabrice)
Comment 2•11 years ago
|
||
Btw, we've got test automation hooked up in the tree. So bonus points if you include a test.
Assignee | ||
Comment 3•11 years ago
|
||
ok, I'll try to include one.
Comment 4•11 years ago
|
||
Comment on attachment 734125 [details] [diff] [review] patch v1 Review of attachment 734125 [details] [diff] [review]: ----------------------------------------------------------------- Please file a followup for the tests (we still need to land the packaged apps tests, bug 821589)
Attachment #734125 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 734125 [details] [diff] [review] patch v1 NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): - User impact if declined: normally, when a unrecoverable errors happen, the update notification should be removed (see Bug 837193). With this bug, this does not happen for some errors. So this is a low user impact but since the change is small I think this is worth it. Testing completed: yes Risk to taking this patch (and alternatives if risky): low String or UUID changes made by this patch: none
Attachment #734125 -
Flags: approval-mozilla-b2g18?
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•11 years ago
|
||
Filed Bug 859258 for the test.
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7307ecec02c
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e7307ecec02c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Assignee | ||
Updated•11 years ago
|
tracking-b2g18:
--- → ?
Updated•11 years ago
|
status-b2g18:
--- → affected
Updated•11 years ago
|
Attachment #734125 -
Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Comment 9•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g18/rev/f671fa539473
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-firefox21:
--- → wontfix
status-firefox22:
--- → wontfix
status-firefox23:
--- → fixed
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•