858833 - during an update, downloadAvailable is sometimes not reset to false after an error, when it should

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* install a packaged app that you control
* change the update manifest, and corrupt the zip
* check for updates
* accept the update

Expected:
* the update is downloaded and then the notification disappear because the error is not recoverable by the user. After some time a banner shows up explaining there was an error.

Actual:
* the expected behaviour happens, except the notification does not disappear.

This STR should be used with the patch for Bug 837193 which implements the removal of the notification.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: patch v1

When updating an app, the installState is not "installed" but "updating. So I changed the test to test that it's not "pending" instead, as in other places.

The STR works fine with this change.

Comment 2

[Jason Smith [:jsmith]]

Btw, we've got test automation hooked up in the tree. So bonus points if you include a test.

Comment 3

[Julien Wajsberg [:julienw]]

ok, I'll try to include one.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 734125 [details] [diff] [review]
patch v1

Review of attachment 734125 [details] [diff] [review]:
-----------------------------------------------------------------

Please file a followup for the tests (we still need to land the packaged apps tests, bug 821589)

Comment 5

[Julien Wajsberg [:julienw]]

Comment on attachment 734125 [details] [diff] [review]
patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: normally, when a unrecoverable errors happen, the update notification should be removed (see Bug 837193). With this bug, this does not happen for some errors. So this is a low user impact but since the change is small I think this is worth it.
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 6

[Julien Wajsberg [:julienw]]

Filed Bug 859258 for the test.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e7307ecec02c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e7307ecec02c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/f671fa539473