Closed Bug 858868 Opened 12 years ago Closed 12 years ago

xpcshell tests are broken

Categories

(Firefox Graveyard :: SocialAPI, defect)

Product:
Firefox Graveyard
Component:
SocialAPI
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

fix xpcshell migration patches
8.00 KB, patch
markh
: review+
Details | Diff | Splinter Review
I was all happy about having migration tests, and they were embarrassingly broken.
Assignee: nobody → mixedpuppy
Attachment #734181 - Flags: review?(gavin.sharp)
Blocks: 851936
Comment on attachment 734181 [details] [diff] [review] fix xpcshell migration patches I didn't review this stuff originally, so I'm lacking a lot of context. I can see one bug in the SocialService code that you're changing (using the wrong pref branch), but I don't understand why you're changing the tests. Can you elaborate on what the problems are and why you're making the changes you're making, exactly?
Attachment #734181 - Attachment is patch: true
Attachment #734181 - Flags: review?(mhammond)
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #2) > I can see one bug in the SocialService code that you're changing (using the > wrong pref branch), but I don't understand why you're changing the tests. > Can you elaborate on what the problems are and why you're making the changes > you're making, exactly? Apparently xpcshell tests don't fail on exceptions inside our callback function, so the tests were passing. There was a bug in the callback that caused an exception, then the last check didn't run. That last check would have caught the problem in the migration function.
Comment on attachment 734181 [details] [diff] [review] fix xpcshell migration patches Looks good to me. I guess I should have picked up that an explicit callback was going to be a problem with AsyncRunner() - bring on promises so some of these "clever" repurposing of generators can die :)
Attachment #734181 - Flags: review?(mhammond) → review+
Attachment #734181 - Flags: review?(gavin.sharp)
https://hg.mozilla.org/mozilla-central/rev/a19f9df3a7a0
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: