85887 - Gzip content not properly displayed when using Content-Encoding: x-gzip

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Olivier Cahagne]

Mozilla: 20010613
OS: Win2k SP1

Steps to reproduce:
Load URL:
http://cvsweb.netbsd.org/
Result: garbage
Expected result: normal HTML page with links, etc.

Perhaps gzip is broken or recently broke ?

Sniffer shows these headers sent to the browser:
[...]
Content-Encoding: x-gzip\r\n
Vary: Accept-Encoding: x-gzip\r\n
[...]

Comment 1

[David Einstein]

This is an antidup of bug 35956.  I believe that the fix for that bug broke this.

Comment 2

[David Einstein]

The component should be Networking HTTP. I lack the power to change it.

Comment 3

[Olivier Cahagne]

Changing component to Networking HTTP

Comment 4

[Doron Rosenberg (IBM)]

really moving

Comment 5

[David Einstein]

The problem here is that the server says
Content-Encoding: x-gzip

after mozilla said
Accept-Encoding: gzip,deflate,compress,identity

While the HTTP 1.1 spec says
Use of program names for the identification of encoding formats
is not desirable and is discouraged for future encodings. Their
use here is representative of historical practice, not good
design. For compatibility with previous implementations of HTTP,
applications SHOULD consider "x-gzip" and "x-compress" to be
equivalent to "gzip" and "compress" respectively.

Comment 6

[Bradley Baetz (:bbaetz)]

-> darin

Comment 7

[David Einstein]

The following will fix it but is almost certainly the wrong way.
It works with this change.

diff -u -r1.21 nsHttpChannel.cpp
--- nsHttpChannel.cpp	2001/06/13 22:44:46	1.21
+++ nsHttpChannel.cpp	2001/06/14 18:36:58
@@ -338,6 +338,7 @@
     }
 
     const char *val = mResponseHead->PeekHeader(nsHttp::Content_Encoding);
+
if (val &&
((0==PL_strcasecmp(val,"x-gzip"))||(0==PL_strcasecmp(val,"x-compress")))) val+=2;
     if (val && PL_strcasestr(nsHttpHandler::get()->AcceptEncodings(), val)) {
         nsCOMPtr<nsIStreamConverterService> serv;
         nsresult rv = nsHttpHandler::get()->

Comment 8

[Darin Fisher]

David: right, we need to do something like that.  I'd like to simply add a 
method to nsHttpHandler that checks for a valid encoding.  

Comment 9

[David Einstein]

Attachment: A slightly cleaner fix

Comment 10

[Darin Fisher]

Attachment: simplified/cleaned-up patch

Comment 11

[Bradley Baetz (:bbaetz)]

r=bbaetz

Comment 12

[Matthew Cline]

Seeing this on Linux; chaning OS to All.

Comment 13

[Doug Turner (:dougt)]

I want this.  (s)r=me.

Comment 14

[David Einstein]

*** Bug 86500 has been marked as a duplicate of this bug. ***

Comment 15

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 16

[Darin Fisher]

fix checked in.

Comment 17

[Bradley Baetz (:bbaetz)]

VERIFIED June 22 morning CVS build on linux