Closed Bug 858909 Opened 8 years ago Closed 8 years ago

[Oracle] When running checksetup.pl for the first time using Oracle as DB server, you get an "uninitialized value" warning

Categories

(Bugzilla :: Installation & Upgrading, defect)

4.0.3
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

Attachments

(1 file)

When running checksetup.pl for the first time using Oracle as DB server, you get an "uninitialized value" warning, because data/params doesn't exist yet:

  Use of uninitialized value in subroutine entry at Bugzilla/DB/Oracle.pm line 62

This line 62 is:

  max(Bugzilla->params->{'maxattachmentsize'}, MIN_LONG_READ_LEN) * 1024

As data/params doesn't exist yet, maxattachmentsize is undefined and max() complains. This warning is present since Bugzilla 4.0.3, see bug 701350.
Attached patch patch, v1Splinter Review
Assignee: installation → LpSolit
Status: NEW → ASSIGNED
Attachment #734223 - Flags: review?(dkl)
Comment on attachment 734223 [details] [diff] [review]
patch, v1

Review of attachment 734223 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #734223 - Flags: review?(dkl) → review+
Flags: approval4.4+
Flags: approval4.2+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/DB/Oracle.pm
Committed revision 8615.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/DB/Oracle.pm
Committed revision 8548.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified Bugzilla/DB/Oracle.pm
Committed revision 8209.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.