701350 - Oracle crashes if the 'maxattachmentsize' parameter is set to a too small value

Status: RESOLVED FIXED

(Bugzilla :: Database, defect)

Description

[Arnaud Hocevar]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111104165243

Steps to reproduce:

I created a default setup of Bugzilla, using Oracle 11 as database backend. I changed the max attachement size from 512k to 4k in the Administration -> Preferences -> Attachement.


Actual results:

Bugzilla throws the following error. It looks like the whole site is not accessible anymore :

DBD::Oracle::db selectrow_array failed: ERROR fetching field 1 of 2. LOB value truncated from 180107 to 4096. DBI attribute LongReadLen too small and/or LongTruncOk not set [for Statement "SELECT schema_data, version FROM bz_schema"] at Bugzilla/DB/Oracle.pm line 412
	Bugzilla::DB::Oracle::selectrow_array(undef, 'SELECT schema_data, version FROM bz_schema') called at Bugzilla/DB.pm line 1254
	Bugzilla::DB::_bz_real_schema('Bugzilla::DB::Oracle=HASH(0x1a65e628)') called at Bugzilla/DB.pm line 1000
	Bugzilla::DB::bz_column_info('Bugzilla::DB::Oracle=HASH(0x1a65e628)', 'groups', 'id') called at Bugzilla/Object.pm line 444
	Bugzilla::Object::_check_field('Bugzilla::Group', 'id', 'match') called at Bugzilla/Object.pm line 228
	Bugzilla::Object::match('Bugzilla::Group', 'HASH(0x1a8f4338)') called at Bugzilla/Object.pm line 179
	Bugzilla::Object::new_from_list('Bugzilla::Group', 'ARRAY(0x1a8f3f90)') called at Bugzilla/User.pm line 603
	Bugzilla::User::groups('Bugzilla::User=HASH(0x1a760340)') called at Bugzilla/User.pm line 667
	Bugzilla::User::in_group('Bugzilla::User=HASH(0x1a760340)', 'tweakparams') called at /local/amadeus/bugzilla/editparams.cgi line 47


Expected results:

The administration interface should have prevented from reducing the size to this level if it caused such fatal error.

Comment 1

[Arnaud Hocevar]

To fix the error, update manually $datadir/params and set maxattachmentsize to a size rgeater than the one in the previous error (256 worked for me)

Comment 2

[Frédéric Buclin]

Confirmed.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Comment 4

[Max Kanat-Alexander]

Comment on attachment 577406 [details] [diff] [review]
patch, v1

Review of attachment 577406 [details] [diff] [review]:
-----------------------------------------------------------------

::: Bugzilla/DB/Oracle.pm
@@ +73,2 @@
>      my $attrs = { FetchHashKeyName => 'NAME_lc',  
> +                  LongReadLen => max($attachment_max_size, 1000) * 1024,

Ah, actually, it will have to be the largest that maxattachmentsize *ever* was.

Perhaps it should go into a constant and be something like 32MB.

Comment 5

[Frédéric Buclin]

Attachment: patch, v2

Comment 6

[Max Kanat-Alexander]

Comment on attachment 577418 [details] [diff] [review]
patch, v2

Review of attachment 577418 [details] [diff] [review]:
-----------------------------------------------------------------

::: Bugzilla/DB/Oracle.pm
@@ +70,4 @@
>      my $dsn = "dbi:Oracle:host=$host;sid=$dbname";
>      $dsn .= ";port=$port" if $port;
>      my $attrs = { FetchHashKeyName => 'NAME_lc',  
> +                  LongReadLen => LOB_MAX_SIZE,

But then if somebody sets maxattachmentsize larger than that, we'll fail again.

Comment 7

[Frédéric Buclin]

Attachment: patch, v3

Comment 8

[Max Kanat-Alexander]

Comment on attachment 577752 [details] [diff] [review]
patch, v3

Review of attachment 577752 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful.

Comment 9

[Max Kanat-Alexander]

Comment on attachment 577752 [details] [diff] [review]
patch, v3

Review of attachment 577752 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, except rename the constant to LONG_READ_LEN_MIN on checkin, or something like that.

Comment 10

[Max Kanat-Alexander]

Probably MIN_LONG_READ_LEN to be consistent with other constants.

Comment 11

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/DB/Oracle.pm
Committed revision 8028.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified Bugzilla/DB/Oracle.pm
Committed revision 7971.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified Bugzilla/DB/Oracle.pm
Committed revision 7662.