858978 - Regression: Vertical line on URL bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (04/06) - Screenshot

Very recent regression. See screenshot.

Sriram bug?

--
Nightly (04/06)
LG Nexus 4 (Android 4.2.2)

Comment 1

[Aaron Train [:aaronmt]]

I tried a couple devices (Note II, Galaxy Nexus, Nexus S), I think it's a Nexus 4 thing. Anyone else seeing this elsewhere?

Comment 2

[Chris Peterson [:cpeterson]]

I noticed this line on my Nexus 4. Is this bug related to the Nexus 4 display's dpi?

Comment 3

[Sriram Ramasubramanian [:sriram]]

(In reply to Chris Peterson (:cpeterson) from comment #2)
> I noticed this line on my Nexus 4. Is this bug related to the Nexus 4
> display's dpi?

I might be a combination of Nexus 4's dpi (which might be 2.133 or something) and the float calculations.

Comment 5

[Lucas Rocha (:lucasr)]

Sriram, maybe a regression from bug 848719?

Comment 6

[Mark Capella [:capella]]

Dup of bug 860296 ?

Comment 7

[Aaron Train [:aaronmt]]

(In reply to Mark Capella [:capella] from comment #6)
> Dup of bug 860296 ?

Nah this one is static, always visible on the bar.

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

Reported by a user on a HTC One S as well.

Comment 9

[Aaron Train [:aaronmt]]

Forgot to comment here last week, I noticed that in landscape orientation the vertical line is removed.

Comment 10

[Ian Barlow (:ibarlow)]

Nominating as bug #1 for the UI Hackathon :)

This thing is making my eyes bleed

Comment 11

[:Margaret Leibovic]

Do we have a regression range on this bug?

Comment 12

[Aaron Train [:aaronmt]]

Yes

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8fc33d047ed6&tochange=c99b61f740d7

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Also seen on my HTC Sensation 4G running ICS.

Comment 14

[Lucas Rocha (:lucasr)]

Attachment: Use DST_IN to draw ShapedButton

It seems that using DST_OUT to draw ShapedButtons might cause subpixel artifacts close to the view boundaries. We can avoid that by using DST_IN instead.

Comment 15

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/72ee55092cb8

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/72ee55092cb8

Comment 17

[Lucas Rocha (:lucasr)]

Comment on attachment 741559 [details] [diff] [review]
Use DST_IN to draw ShapedButton

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 848719
User impact if declined: Visual artifact on browser toolbar in some devices
Testing completed (on m-c, etc.): Landed on m-c, no issues.
Risk to taking this patch (and alternatives if risky): Very low, patch is fairly simple.
String or IDL/UUID changes made by this patch: n/a

Comment 18

[bhavana bajaj [:bajaj]]

Comment on attachment 741559 [details] [diff] [review]
Use DST_IN to draw ShapedButton

regression on Fx22 and has a low risk patch.Approving !

Comment 19

[Lucas Rocha (:lucasr)]

Pushed to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/175e1e444db4