85908 - Add reload to View Page Source Window

Status: RESOLVED FIXED

(Core Graveyard :: View Source, enhancement)

Description

[poelzi]

View Source window should have View -> Reload

Comment 1

[sairuh (rarely reading bugmail)]

confirming rfe.

Comment 2

[poelzi]

i tryed to fix with adding

<menuitem accesskey="&reloadCmd.accesskey;" key="key_reload"
label="&reloadCmd.label;" command="Browser:Reload"/>

but no result. where is the problem ? i try to understand this holy mass of
code, ohh thats so complicated... :)

Comment 3

[Doron Rosenberg (IBM)]

i actually had this working once, I think timeless asked it.  However, i still
fail to see a realy use for it, especially since i had to cut "open welocation"
from the viewsource UI.

Comment 4

[Blake Ross]

--> doron

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 118317 has been marked as a duplicate of this bug. ***

Comment 6

[sairuh (rarely reading bugmail)]

mass moving open bugs pertaining to view source to [e-mail] as qa contact.

to find all bugspam pertaining to this, set your search string to
"ItsSharkeysNight".

Comment 7

[R.K.Aa.]

*** Bug 143215 has been marked as a duplicate of this bug. ***

Comment 8

[Jonas Jørgensen]

--> ViewSource

Comment 9

[[e-mail]]

Attachment: Proposed patch

Comment 10

[[e-mail]]

Hmm... reload doesn't seem to have quite the effect I want. Maybe I should just
go with reload skip cache all the time.

Comment 11

[Doron Rosenberg (IBM)]

Comment on attachment 89381 [details] [diff] [review]
Proposed patch

Don't call functions BrowserFoo in viewsource :)

Comment 12

[Ken Johanson]

Just noting that I'm hoping the fix will also support CTLR-R reloads. -I use
that left and right on NS4. :->

Comment 13

[Boris Zbarsky [:bzbarsky]]

Hrm.  Cache. Right.  The current implementation of nsViewSourceChannel will
_always_ try to read from cache if possible.  You may have to deal with that if
you want this to actually reload from network....

Comment 14

[[e-mail]]

Doron, sorry, I was hoping to get F5 automatically - F5 calls BrowserReload().
Unfortunately I'd forgotton to overlay platformNavigationBindings.xul :-)

Comment 15

[[e-mail]]

Attachment: Fix F5

Also always skips cache.

Comment 16

[Doron Rosenberg (IBM)]

I still don't see you overlaying anything

Comment 17

[[e-mail]]

> I still don't see you overlaying anything

In fact I was overlaying (it's not explicit) I just wasn't pulling the key in :-)

Comment 18

[Henrik Lynggaard Hansen]

Requesting blocking 1.4. We got a patch, lets review and get it in if it is good.

Comment 19

[Doron Rosenberg (IBM)]

Is this realllly needed?  Care to explain why this is needed?

Also, I think edit page in viewsource should go :)

Comment 20

[poelzi]

This is very usefull for programming of dynamic web sites.

Comment 21

[Ken Johanson]

To the question of "why is it needed"; Code-level web developers, i.e. JSP, PHP,
PERL, ASP, etc) frequently need to debug the raw output from the webserver when
they make changes -- just viewing the changes on the rendered page is of
marginal value (take XML or XSL output for example). Without this feature, code
writers are relagated to having to:

1) make changes server-side
2) reloading the URL (ctrl-r or f)
3) view source (ctrl-u)
4) scroll-to and review the code segment in question
5) close the old (stagnate) view source window
6) focus on the rendered (main) browser window, and repeat as neccesary

compared to:
1) view source, just one time (ctrl-u) 
2) reload view source window (ideally, without need to re-scroll to the code in
question, similar to the behavior of the main window when reloading)
3) make changes server-side, --> step 2 as neccesary
4) close the view source window (just one time), after fixing code in question.

Comment 22

[Doron Rosenberg (IBM)]

hmm. Neil, can you rename the functions to not contain 
"browser" :)

Comment 23

[Adam Hauner]

BTW View source in NN4.78 has this feature.

Comment 24

[Doron Rosenberg (IBM)]

Comment on attachment 89673 [details] [diff] [review]
Fix F5

+      <menu id="tasksMenu"/>

Why are you adding all these menus?  Also, please change the name of the
functions to be ViewSource* perhaps.

Comment 25

[Pascal Chevrel:pascalc (PTO until April 26)]

Since this is a 4xp bug, shouldn't it be a normal bug and not an "enhancement
request" ? BTW, if it could land for 1.4, it would be great since this feature
would be one more argument in favor of Mozilla/Netscape for evangelizing web
developpers.

Comment 26

[SylvainZilla]

I found this usefull :
http://placenamehere.com/pnhtoolbar/
In the toolbar, there's a "view-source" that open a tab with the source.

with SHIFT+CTRL+R it's possible to reload from the source.

It works with Phoenix 0.5 Fr and Netscape 7.02 FR

Comment 27

[[e-mail]]

Comment on attachment 89673 [details] [diff] [review]
Fix F5

I can't rename the functions because that's what F5 and Ctrl+F5 expect to use.

Comment 28

[Doron Rosenberg (IBM)]

hmm, why the tasks menu then? other than that its fine.

Comment 29

[[e-mail]]

Attachment: Removed tasks

Comment 30

[Doron Rosenberg (IBM)]

Comment on attachment 130068 [details] [diff] [review]
Removed tasks

looks fine to me.

Comment 31

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 130068 [details] [diff] [review]
Removed tasks

sr=me; test well to make sure this really does reload the source...

Comment 32

[[e-mail]]

Fix checked in.

Comment 33

[Ken Johanson]

It almost works - for me, I get a cached view of a dynamic content URL. A good
example is a login page where the login form URL stays the same after the person
logs in - I noticed some other bugs stating that the view srource window isnt
sending cookies - guessing this is the cause. Otherwise AWESOME!!!! :)

Comment 34

[Boris Zbarsky [:bzbarsky]]

*** Bug 225510 has been marked as a duplicate of this bug. ***