Closed Bug 859125 Opened 7 years ago Closed 7 years ago

Clean up confvars.sh and configure.in

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 23.0

People

(Reporter: jcranmer, Assigned: neil)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #846540 +++

@@ +92,5 @@
> +AC_SUBST(LDAP_CFLAGS)
> +AC_SUBST(LDAP_LIBS)
> +
> +# Rerun the confvars, since we need to add to our components list.
> +. "${srcdir}/${MOZ_BUILD_APP}/confvars.sh"

I'd rather move to here, the stuff we *need* to do after these magic lines run from confvars.sh. Now that we have the app-specific configure.in so that we can avoid the re-run of confvars.sh (re-entrancy makes for poor bed fellows there)
Attached patch WIPSplinter Review
This is the minimum necessary to get external builds working. Please let me know if there is any other cleanup that you were thinking of that I can include.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #740760 - Flags: feedback?(Pidgeot18)
I mean external API, of course.

The problem with the current code is that the external API flag isn't set the first time confvars.sh runs, so the toolkit build always gets set up for internal components.
Attachment #740760 - Flags: feedback?(Pidgeot18) → feedback+
Comment on attachment 740760 [details] [diff] [review]
WIP

I couldn't find any useless use of AC_SUBST, so the patch remains unchanged.
Attachment #740760 - Flags: review?(bugspam.Callek)
Comment on attachment 740760 [details] [diff] [review]
WIP

Looks good. r=Standard8.
Attachment #740760 - Flags: review?(bugspam.Callek) → review+
Pushed comm-central changeset 50dcb67013a5.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
Depends on: 877132
You need to log in before you can comment on or make changes to this bug.