859136 - Requests with an image response should display a thumbnail near the file name

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Victor Porof [:vporof][:vp]]

It would also be nice if the image was shown as a thumbnail in the requests menu. This would make it super easy to spot certain requests.

Comment 1

[Victor Porof [:vporof][:vp]]

Moving into Developer Tools: Netmonitor component. Filter on NETMONITORAMA.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1 wip

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v2

Comment 4

[Victor Porof [:vporof][:vp]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=6a34475c4b5a

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8375425 [details] [diff] [review]
v2

Review of attachment 8375425 [details] [diff] [review]:
-----------------------------------------------------------------

looks good. we have a follow-up for the icons for the other filetypes?

::: browser/devtools/netmonitor/test/head.js
@@ +39,5 @@
>  const STATUS_CODES_SJS = EXAMPLE_URL + "sjs_status-codes-test-server.sjs";
>  const SORTING_SJS = EXAMPLE_URL + "sjs_sorting-test-server.sjs";
>  
>  const TEST_IMAGE = EXAMPLE_URL + "test-image.png";
> +const TEST_IMAGE_DATA_URI = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAABGdBTUEAAK/INwWK6QAAABl0RVh0U29mdHdhcmUAQWRvYmUgSW1hZ2VSZWFkeXHJZTwAAAHWSURBVHjaYvz//z8DJQAggJiQOe/fv2fv7Oz8rays/N+VkfG/iYnJfyD/1+rVq7ffu3dPFpsBAAHEAHIBCJ85c8bN2Nj4vwsDw/8zQLwKiO8CcRoQu0DxqlWrdsHUwzBAAIGJmTNnPgYa9j8UqhFElwPxf2MIDeIrKSn9FwSJoRkAEEAM0DD4DzMAyPi/G+QKY4hh5WAXGf8PDQ0FGwJ22d27CjADAAIIrLmjo+MXA9R2kAHvGBA2wwx6B8W7od6CeQcggKCmCEL8bgwxYCbUIGTDVkHDBia+CuotgACCueD3TDQN75D4xmAvCoK9ARMHBzAw0AECiBHkAlC0Mdy7x9ABNA3obAZXIAa6iKEcGlMVQHwWyjYuL2d4v2cPg8vZswx7gHyAAAK7AOif7SAbOqCmn4Ha3AHFsIDtgPq/vLz8P4MSkJ2W9h8ggBjevXvHDo4FQUQg/kdypqCg4H8lUIACnQ/SOBMYI8bAsAJFPcj1AAEEjwVQqLpAbXmH5BJjqI0gi9DTAAgDBBCcAVLkgmQ7yKCZxpCQxqUZhAECCJ4XgMl493ug21ZD+aDAXH0WLM4A9MZPXJkJIIAwTAR5pQMalaCABQUULttBGCCAGCnNzgABBgAMJ5THwGvJLAAAAABJRU5ErkJggg==";

do we need this available to every test? ok, I guess.

Comment 6

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> Comment on attachment 8375425 [details] [diff] [review]
> v2
> 
> Review of attachment 8375425 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> looks good. we have a follow-up for the icons for the other filetypes?
> 

Bug 972880.

Comment 7

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/7a3ccf996b85

Comment 8

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/7a3ccf996b85

Comment 9

[Andrei Vaida [:avaida]]

I was able to confirm the fix for this issue on Firefox 30 Beta 4 (Build ID: 20140512231802), using:
  * Windows 7 64-bit [1],
  * Mac OS X 10.9.2 [2],
  * Ubuntu 13.04 64-bit [3].


[1] Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
[2] Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0
[3] Mozilla/5.0 (X11; Linux x86_64; rv:30.0) Gecko/20100101 Firefox/30.0