Closed Bug 859220 Opened 12 years ago Closed 12 years ago

B2G RIL: Separate MozIccManager from MozMobileConnection

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla24

People

(Reporter: edgar, Assigned: edgar)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(4 files, 13 obsolete files)

Part 1: Separate mozIccManager from mozMobileConnection (IDL), v5, r=allstars.chh, sr=sicking
3.37 KB, patch
edgar
: review+
edgar
: superreview+
Details | Diff | Splinter Review
Part 3: Separate IPC messages in RadioInterfaceLayer, v4, r=allstars.chh
4.23 KB, patch
edgar
: review+
Details | Diff | Splinter Review
Part 4: Fix marionette tests for IccManager, v3, r=allstars.chh
15.42 KB, patch
edgar
: review+
Details | Diff | Splinter Review
Part 2: Separate mozIccManager from mozMobileConnection (DOM), v5, r=smaug
11.28 KB, patch
edgar
: review+
Details | Diff | Splinter Review 
In bug 857414, we plan to move all icc/sim related stuff into mozIccManger. Currently mozIccManager is inside mozMobileConnection [1]. The very first step is separating mozIccManger from mozMobileConnection and putting it into navigator. In this way, it makes mozIccManager and mozMobileConnection both have a clearly defined functionality.

Thanks.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/network/interfaces/nsIDOMMobileConnection.idl#59
Attachment #734511 - Flags: feedback?(bugs)
Hi :smaug,

We plan to put all sim/icc related functionality into IccManager, like Sim Toolkit, get icc/sim information, access icc/sim contacts ... etc.
In Bug 744714 Comment 75, you had a concern about the naming, 'mozIcc', in .navigator.
I would like to use 'mozIccManger' in .navigator to make this property more clear.

Do you have any suggestion? :)

Thanks
Comment on attachment 734511 [details] [diff] [review]
Part 1: Separate mozIccManager from mozMobileConnection (IDL), v1

nsIDOMNavigatorIccManager should be called nsINavigatorIccManager

And yes .iccManager sounds a bit better than .icc. icc doesn't really mean
much in web context.
Attachment #734511 - Flags: feedback?(bugs) → feedback+
Address smaug's feedback in comment #3. Thanks.
Attachment #734511 - Attachment is obsolete: true
Remove forward declaration ,'interface nsIDOMMozIccManager', in nsIDOMMobileConnection.idl.
Attachment #735065 - Attachment is obsolete: true
Change the UUID of nsIDOMMozMobileConnection
Attachment #738307 - Attachment is obsolete: true
Attachment #738310 - Flags: superreview?(jonas)
Attachment #738310 - Flags: review?(allstars.chh)
1). Rebase
2). Use 'mobileconnection' permission. (bug 848684 comment #3)
Attachment #735066 - Attachment is obsolete: true
Use 'mobileconnection' permission. (bug 848684 comment #3)
Attachment #735067 - Attachment is obsolete: true
Attachment #738325 - Flags: review?(allstars.chh)
Use 'mobileconnection' permission. (bug 848684 comment #3)
Attachment #735068 - Attachment is obsolete: true
Attachment #738327 - Flags: review?(allstars.chh)
Attachment #738310 - Flags: review?(allstars.chh) → review+
Comment on attachment 738325 [details] [diff] [review]
Part 3: Separate IPC messages in RadioInterfaceLayer, v2

Review of attachment 738325 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +1912,5 @@
>          for (let msgname of RIL_IPC_MOBILECONNECTION_MSG_NAMES) {
>            ppmm.removeMessageListener(msgname, this);
>          }
> +        for (let msgname of RIL_IPC_ICCMANAGER_MSG_NAMES) {
> +          ppmm.removeMessageListener(msgname, this);

Can you s/msgname/msgName/g in this block?
Attachment #738325 - Flags: review?(allstars.chh) → review+
Attachment #738327 - Flags: review?(allstars.chh) → review+
Version: unspecified → Trunk
Attachment #738325 - Attachment is obsolete: true
Comment on attachment 738314 [details] [diff] [review]
Part 2: Separate mozIccManager from mozMobileConnection (DOM), v2


>+//*****************************************************************************
>+//    nsNavigator::nsINavigatorIccManager

nsIMozNavigatorIccManager, right?
Attachment #738314 - Flags: review?(bugs) → review+
s/nsINavigatorIccManager/nsIMozNavigatorIccManager
Attachment #738314 - Attachment is obsolete: true
Attachment #738413 - Flags: review+
try server result: https://tbpl.mozilla.org/?tree=Try&rev=cdae9bf1ed4f
Version: Trunk → unspecified
Version: unspecified → Trunk
(In reply to Edgar Chen [:edgar][:echen] from comment #9)
> Created attachment 738310 [details] [diff] [review]
> Part 1: Separate mozIccManager from mozMobileConnection (IDL), v4

Hi Jonas:

This bug is to split IccManager and MobileConnection to have a more clear API design.
Needs your help to review the interface changes when your are available.

Thanks in advance.
Attachment #738310 - Flags: superreview?(jonas) → superreview+
We should wait Gaia have a patch for corresponding changes first. (bug 859712)
Gaia has already provided corresponding changes, now we can land this.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4bbefbb00abc
https://hg.mozilla.org/mozilla-central/rev/9668796a2d86
https://hg.mozilla.org/mozilla-central/rev/6aa115917a4d
https://hg.mozilla.org/mozilla-central/rev/7c9541653781
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fix-in-birch] → [fixed-in-birch]
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: