B2G RIL: Separate MozIccManager from MozMobileConnection

RESOLVED FIXED in mozilla24

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: edgar, Assigned: edgar)

Tracking

Trunk
mozilla24
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-birch])

Attachments

(4 attachments, 13 obsolete attachments)

3.37 KB, patch
edgar
: review+
Details | Diff | Splinter Review
4.23 KB, patch
edgar
: review+
Details | Diff | Splinter Review
15.42 KB, patch
edgar
: review+
Details | Diff | Splinter Review
11.28 KB, patch
edgar
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
In bug 857414, we plan to move all icc/sim related stuff into mozIccManger. Currently mozIccManager is inside mozMobileConnection [1]. The very first step is separating mozIccManger from mozMobileConnection and putting it into navigator. In this way, it makes mozIccManager and mozMobileConnection both have a clearly defined functionality.

Thanks.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/network/interfaces/nsIDOMMobileConnection.idl#59
(Assignee)

Updated

6 years ago
Blocks: 857414
(Assignee)

Comment 1

6 years ago
Created attachment 734511 [details] [diff] [review]
Part 1: Separate mozIccManager from mozMobileConnection (IDL), v1
(Assignee)

Updated

6 years ago
Attachment #734511 - Flags: feedback?(bugs)
(Assignee)

Comment 2

6 years ago
Hi :smaug,

We plan to put all sim/icc related functionality into IccManager, like Sim Toolkit, get icc/sim information, access icc/sim contacts ... etc.
In Bug 744714 Comment 75, you had a concern about the naming, 'mozIcc', in .navigator.
I would like to use 'mozIccManger' in .navigator to make this property more clear.

Do you have any suggestion? :)

Thanks
Comment on attachment 734511 [details] [diff] [review]
Part 1: Separate mozIccManager from mozMobileConnection (IDL), v1

nsIDOMNavigatorIccManager should be called nsINavigatorIccManager

And yes .iccManager sounds a bit better than .icc. icc doesn't really mean
much in web context.
Attachment #734511 - Flags: feedback?(bugs) → feedback+
(Assignee)

Updated

6 years ago
Blocks: 859712
(Assignee)

Comment 4

6 years ago
Created attachment 735065 [details] [diff] [review]
Part 1: Separate mozIccManager from mozMobileConnection (IDL), v2

Address smaug's feedback in comment #3. Thanks.
Attachment #734511 - Attachment is obsolete: true
(Assignee)

Comment 5

6 years ago
Created attachment 735066 [details] [diff] [review]
Part 2: Separate mozIccManager from mozMobileConnection (DOM), v1
(Assignee)

Comment 6

6 years ago
Created attachment 735067 [details] [diff] [review]
Part 3: Separate IPC messages in RadioInterfaceLayer, v1
(Assignee)

Comment 7

6 years ago
Created attachment 735068 [details] [diff] [review]
Part 4: Fix marionette tests for IccManager, v1
(Assignee)

Updated

6 years ago
Depends on: 848684
(Assignee)

Updated

6 years ago
Blocks: 860585
(Assignee)

Updated

6 years ago
Blocks: 861083
(Assignee)

Comment 8

6 years ago
Created attachment 738307 [details] [diff] [review]
Part 1: Separate mozIccManager from mozMobileConnection (IDL), v3

Remove forward declaration ,'interface nsIDOMMozIccManager', in nsIDOMMobileConnection.idl.
Attachment #735065 - Attachment is obsolete: true
(Assignee)

Comment 9

6 years ago
Created attachment 738310 [details] [diff] [review]
Part 1: Separate mozIccManager from mozMobileConnection (IDL), v4

Change the UUID of nsIDOMMozMobileConnection
Attachment #738307 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #738310 - Flags: superreview?(jonas)
Attachment #738310 - Flags: review?(allstars.chh)
(Assignee)

Comment 10

6 years ago
Created attachment 738314 [details] [diff] [review]
Part 2: Separate mozIccManager from mozMobileConnection (DOM), v2

1). Rebase
2). Use 'mobileconnection' permission. (bug 848684 comment #3)
Attachment #735066 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #738314 - Flags: review?(bugs)
(Assignee)

Comment 11

6 years ago
Created attachment 738325 [details] [diff] [review]
Part 3: Separate IPC messages in RadioInterfaceLayer, v2

Use 'mobileconnection' permission. (bug 848684 comment #3)
Attachment #735067 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #738325 - Flags: review?(allstars.chh)
(Assignee)

Comment 12

6 years ago
Created attachment 738327 [details] [diff] [review]
Part 4: Fix marionette tests for IccManager, v2

Use 'mobileconnection' permission. (bug 848684 comment #3)
Attachment #735068 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #738327 - Flags: review?(allstars.chh)
Attachment #738310 - Flags: review?(allstars.chh) → review+
Comment on attachment 738325 [details] [diff] [review]
Part 3: Separate IPC messages in RadioInterfaceLayer, v2

Review of attachment 738325 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +1912,5 @@
>          for (let msgname of RIL_IPC_MOBILECONNECTION_MSG_NAMES) {
>            ppmm.removeMessageListener(msgname, this);
>          }
> +        for (let msgname of RIL_IPC_ICCMANAGER_MSG_NAMES) {
> +          ppmm.removeMessageListener(msgname, this);

Can you s/msgname/msgName/g in this block?
Attachment #738325 - Flags: review?(allstars.chh) → review+
Attachment #738327 - Flags: review?(allstars.chh) → review+
Version: unspecified → Trunk
(Assignee)

Comment 14

6 years ago
Created attachment 738386 [details] [diff] [review]
Part 3: Separate IPC messages in RadioInterfaceLayer, v3, r=allstars.chh

Address reviewed comment #13
Attachment #738386 - Flags: review+
(Assignee)

Updated

6 years ago
Attachment #738325 - Attachment is obsolete: true
Comment on attachment 738314 [details] [diff] [review]
Part 2: Separate mozIccManager from mozMobileConnection (DOM), v2


>+//*****************************************************************************
>+//    nsNavigator::nsINavigatorIccManager

nsIMozNavigatorIccManager, right?
Attachment #738314 - Flags: review?(bugs) → review+
(Assignee)

Comment 16

6 years ago
Created attachment 738413 [details] [diff] [review]
Part 2: Separate mozIccManager from mozMobileConnection (DOM), v3, r=smaug

s/nsINavigatorIccManager/nsIMozNavigatorIccManager
Attachment #738314 - Attachment is obsolete: true
Attachment #738413 - Flags: review+
(Assignee)

Comment 17

6 years ago
try server result: https://tbpl.mozilla.org/?tree=Try&rev=cdae9bf1ed4f
Version: Trunk → unspecified
(Assignee)

Updated

6 years ago
Version: unspecified → Trunk
(Assignee)

Comment 18

6 years ago
(In reply to Edgar Chen [:edgar][:echen] from comment #9)
> Created attachment 738310 [details] [diff] [review]
> Part 1: Separate mozIccManager from mozMobileConnection (IDL), v4

Hi Jonas:

This bug is to split IccManager and MobileConnection to have a more clear API design.
Needs your help to review the interface changes when your are available.

Thanks in advance.
Attachment #738310 - Flags: superreview?(jonas) → superreview+
(Assignee)

Comment 19

6 years ago
We should wait Gaia have a patch for corresponding changes first. (bug 859712)
(Assignee)

Updated

6 years ago
Blocks: 870237
(Assignee)

Comment 20

6 years ago
Created attachment 747830 [details] [diff] [review]
Part 1: Separate mozIccManager from mozMobileConnection (IDL), v5, r=allstars.chh, sr=sicking

Rebase
Attachment #738310 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #747830 - Flags: review+
(Assignee)

Updated

6 years ago
Attachment #747830 - Flags: superreview+
(Assignee)

Comment 21

6 years ago
Created attachment 747831 [details] [diff] [review]
Part 2: Separate mozIccManager from mozMobileConnection (DOM), v4, r=smaug

Rebase
Attachment #738413 - Attachment is obsolete: true
Attachment #747831 - Flags: review+
(Assignee)

Comment 22

6 years ago
Created attachment 747832 [details] [diff] [review]
Part 3: Separate IPC messages in RadioInterfaceLayer, v4, r=allstars.chh

Rebase
Attachment #738386 - Attachment is obsolete: true
(Assignee)

Comment 23

6 years ago
Created attachment 747833 [details] [diff] [review]
Part 4: Fix marionette tests for IccManager, v3, r=allstars.chh

Rebase
Attachment #738327 - Attachment is obsolete: true
Attachment #747833 - Flags: review+
(Assignee)

Updated

6 years ago
Attachment #747832 - Flags: review+
(Assignee)

Comment 25

6 years ago
Created attachment 752007 [details] [diff] [review]
Part 2: Separate mozIccManager from mozMobileConnection (DOM), v5, r=smaug

Rebase
Attachment #747831 - Attachment is obsolete: true
Attachment #752007 - Flags: review+
(Assignee)

Comment 26

6 years ago
Gaia has already provided corresponding changes, now we can land this.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4bbefbb00abc
https://hg.mozilla.org/mozilla-central/rev/9668796a2d86
https://hg.mozilla.org/mozilla-central/rev/6aa115917a4d
https://hg.mozilla.org/mozilla-central/rev/7c9541653781
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fix-in-birch] → [fixed-in-birch]
Target Milestone: --- → mozilla24
(Assignee)

Updated

6 years ago
Blocks: 874744
(Assignee)

Updated

6 years ago
Blocks: 875721
(Assignee)

Updated

6 years ago
Blocks: 884274
You need to log in before you can comment on or make changes to this bug.