859220 - B2G RIL: Separate MozIccManager from MozMobileConnection

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

In bug 857414, we plan to move all icc/sim related stuff into mozIccManger. Currently mozIccManager is inside mozMobileConnection [1]. The very first step is separating mozIccManger from mozMobileConnection and putting it into navigator. In this way, it makes mozIccManager and mozMobileConnection both have a clearly defined functionality.

Thanks.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/network/interfaces/nsIDOMMobileConnection.idl#59

Comment 1

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 1: Separate mozIccManager from mozMobileConnection (IDL), v1

Comment 2

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Hi :smaug,

We plan to put all sim/icc related functionality into IccManager, like Sim Toolkit, get icc/sim information, access icc/sim contacts ... etc.
In Bug 744714 Comment 75, you had a concern about the naming, 'mozIcc', in .navigator.
I would like to use 'mozIccManger' in .navigator to make this property more clear.

Do you have any suggestion? :)

Thanks

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 734511 [details] [diff] [review]
Part 1: Separate mozIccManager from mozMobileConnection (IDL), v1

nsIDOMNavigatorIccManager should be called nsINavigatorIccManager

And yes .iccManager sounds a bit better than .icc. icc doesn't really mean
much in web context.

Comment 4

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 1: Separate mozIccManager from mozMobileConnection (IDL), v2

Address smaug's feedback in comment #3. Thanks.

Comment 5

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 2: Separate mozIccManager from mozMobileConnection (DOM), v1

Comment 6

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 3: Separate IPC messages in RadioInterfaceLayer, v1

Comment 7

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 4: Fix marionette tests for IccManager, v1

Comment 8

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 1: Separate mozIccManager from mozMobileConnection (IDL), v3

Remove forward declaration ,'interface nsIDOMMozIccManager', in nsIDOMMobileConnection.idl.

Comment 9

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 1: Separate mozIccManager from mozMobileConnection (IDL), v4

Change the UUID of nsIDOMMozMobileConnection

Comment 10

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 2: Separate mozIccManager from mozMobileConnection (DOM), v2

1). Rebase
2). Use 'mobileconnection' permission. (bug 848684 comment #3)

Comment 11

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 3: Separate IPC messages in RadioInterfaceLayer, v2

Use 'mobileconnection' permission. (bug 848684 comment #3)

Comment 12

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 4: Fix marionette tests for IccManager, v2

Use 'mobileconnection' permission. (bug 848684 comment #3)

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 738325 [details] [diff] [review]
Part 3: Separate IPC messages in RadioInterfaceLayer, v2

Review of attachment 738325 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +1912,5 @@
>          for (let msgname of RIL_IPC_MOBILECONNECTION_MSG_NAMES) {
>            ppmm.removeMessageListener(msgname, this);
>          }
> +        for (let msgname of RIL_IPC_ICCMANAGER_MSG_NAMES) {
> +          ppmm.removeMessageListener(msgname, this);

Can you s/msgname/msgName/g in this block?

Comment 14

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 3: Separate IPC messages in RadioInterfaceLayer, v3, r=allstars.chh

Address reviewed comment #13

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 738314 [details] [diff] [review]
Part 2: Separate mozIccManager from mozMobileConnection (DOM), v2


>+//*****************************************************************************
>+//    nsNavigator::nsINavigatorIccManager

nsIMozNavigatorIccManager, right?

Comment 16

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 2: Separate mozIccManager from mozMobileConnection (DOM), v3, r=smaug

s/nsINavigatorIccManager/nsIMozNavigatorIccManager

Comment 17

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

try server result: https://tbpl.mozilla.org/?tree=Try&rev=cdae9bf1ed4f

Comment 18

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Edgar Chen [:edgar][:echen] from comment #9)
> Created attachment 738310 [details] [diff] [review]
> Part 1: Separate mozIccManager from mozMobileConnection (IDL), v4

Hi Jonas:

This bug is to split IccManager and MobileConnection to have a more clear API design.
Needs your help to review the interface changes when your are available.

Thanks in advance.

Comment 19

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

We should wait Gaia have a patch for corresponding changes first. (bug 859712)

Comment 20

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 1: Separate mozIccManager from mozMobileConnection (IDL), v5, r=allstars.chh, sr=sicking

Rebase

Comment 21

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 2: Separate mozIccManager from mozMobileConnection (DOM), v4, r=smaug

Rebase

Comment 22

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 3: Separate IPC messages in RadioInterfaceLayer, v4, r=allstars.chh

Rebase

Comment 23

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 4: Fix marionette tests for IccManager, v3, r=allstars.chh

Rebase

Comment 24

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

try server result:
https://tbpl.mozilla.org/?tree=Try&rev=ba0de51f23e7
https://tbpl.mozilla.org/?tree=Try&rev=600772e868ae

Comment 25

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Part 2: Separate mozIccManager from mozMobileConnection (DOM), v5, r=smaug

Rebase

Comment 26

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Gaia has already provided corresponding changes, now we can land this.

Comment 27

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

http://hg.mozilla.org/projects/birch/rev/4bbefbb00abc
http://hg.mozilla.org/projects/birch/rev/9668796a2d86
http://hg.mozilla.org/projects/birch/rev/6aa115917a4d
http://hg.mozilla.org/projects/birch/rev/7c9541653781

Comment 28

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4bbefbb00abc
https://hg.mozilla.org/mozilla-central/rev/9668796a2d86
https://hg.mozilla.org/mozilla-central/rev/6aa115917a4d
https://hg.mozilla.org/mozilla-central/rev/7c9541653781